Hello Tom,
Thanks for giving update on this.
Tom Bostelmann <[EMAIL PROTECTED]> wrote:
Mayank,
Thanks for your patience. The patch looks good. It appears that you have
adequate test coverage and the implementation looks like it covers the spec so
I went ahead and committed your changes.
A couple things that I had to change to make it work:
1.) Updated the db version from 155 to 156 (someone added an upgrade in
between).
2.) Your upgrade/downgrade scripts executed the same sql commands several
times. This just appears to be a fat finger error so I won't get after you
about reviewing you code before you submit it ;)
The feature was added through svn revision 12182.
Thanks!
-Tom
On Nov 2, 2007 3:36 AM, Mayank Upadhayay <[EMAIL PROTECTED] > wrote:
Patch continued.....
Hello Van,
Sorry for late reply
I had broken the patch into two parts, and send it across community in
two mails. I had tried sending it in one patch but fail, because of size
restriction. You need to apply both the patches; I just want to make
sure whether you have applied both the patches. Please find attached
patch1 with this mail; patch2 will be in another mail.
Please let me know if the issue still persists.
Regards and Thanks,
Mayank Upadhayay. Associate Developer. SunGard . Offshore Services .
Divyasree Chambers Langford Road Bangalore 560025 India
Tel +91-80-2222-0501 . Mobile +91-9986731792 . Fax +91-80-2222-0511 .
www.sungard.com
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] ] On Behalf Of Van
Mittal-Henkle
Sent: Thursday, November 01, 2007 12:13 PM
To: Developer
Subject: RE: [Mifos-developer] Patch
Hi Mayank,
Thanks for the patch!
When reviewing the content of the patch it appears that there are a
number of files missing which should be there. I am wondering if
perhaps you accidentally did not include any of the new files you
created. In particular, the patch does not compile because of missing
class files and there are no tests included in it, though from your
message it sounds like there should be tests present.
Please check on this and resubmit an updated patch.
Thanks,
--Van
-----Original Message-----
From: [EMAIL PROTECTED] on behalf of Mayank
Upadhayay
Sent: Wed 10/31/2007 7:38 AM
To: [email protected]
Subject: [Mifos-developer] Patch
Hi All,
I am done with the development of loan defaults based on previous loan
amount (http://www.mifos.org/developers/wiki/LoanDefaults ). Also update
it based on revision no-12168. I am herby sending the patch for review
that includes all the development as well as test cases. During
development I have made some assumptions in terms of functionality as
the requirements are not very clear. Also find attached document that
contains approach used, assumptions made and some open issues with their
solutions.
Apart from that, the inconsistency issues between client and group
(issue no 1477) is there in issue tracker. Once it will be resolved I
will update the code for creating an loan account for group based on
product type-loan cycle.
Thoughts and suggestions are welcomed. Waiting for response...
Regards and Thanks,
Mayank Upadhayay. Associate Developer. SunGard . Offshore Services .
Divyasree Chambers Langford Road Bangalore 560025 India
Tel +91-80-2222-0501 . Mobile +91-9986731792 . Fax +91-80-2222-0511 .
www.sungard.com
P Think before you print
CONFIDENTIALITY: This email (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this email in error,
please notify the sender and delete this email from your system. Thank
you.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
---------------------------------
Now you can chat without downloading messenger. Click here to know how.-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
