Hi Amiruddin,
I have attached log generated by ant when i tried to run all the tests file
ending with *Test.class (mifosbuild.txt) and when you run the test using
ApplicationTestSuite(mifosdefaultbuild.txt).
Some of the tests like ActivityGeneratorTest are not part of any suite.
Thanks for finding the orphaned ActivityGeneratorTest and please let us know if
you discover others.
I also noticed that not all test files end with test, some actually start with
Test while others have 'Test' in between the file name.
Can we try to clean it up and have some logical naming convention like files
ending with 'Test' only tests the behavior inside application,
Currently tests are organized into a hierarchy of test suites that cover
different areas of the application with ApplicationTestSuite being the one that
runs them all. The problem as you have discovered is that someone can neglect
to add a test like ActivityGeneratorTest into the list of tests to run. A
naming convention like xxxTest could be used to run all tests which follow that
convention. In that then the problem would come when someone didn't follow the
naming convention :-)
But no matter how the test runs are organized, I would still be in favor of
using a naming convention for the sake of consistency.
I'll put forward the suggestion of following the convention <classname>Test for
test class names. This convention should make code completion more convenient
than Test<classname>. So the proposal is that when someone writes the class
MyClass then they would write MyClassTest to go along with it..
If anyone else in the community has comments one way or another regarding this,
please chime in. After others have had a chance to comment, then if we're in
agreement, we can put this on our list of refactoring to do.
and can have 'DBTest' and 'ServiceTest' which has some dependency on external
data source so that we can filter it out and run selected functional tests.
Unfortunately, most tests currently have a dependency on the database. So
currently we have few true unit tests and many tests that are more like
functional tests. This is an area that I hope we can improve after our 1.1
release.
Also since this build is taking more time than usual build, probably it is
doing something extra which we are probably missing out in ApplicationTestSuite.
This is certainly possible, but it also may be that you are running certain
tests more than once or that test failures are increasing the run time. A
first thing to do would be to count the total number of tests being run and to
try comparing lists of the lowest level tests that are being run in each case.
Cheers,
--Van
[EMAIL PROTECTED] wrote: -----
To: "Developer" <[email protected]>
From: "Nazir LAJDEL" <[EMAIL PROTECTED]>
Sent by: [EMAIL PROTECTED]
Date: 12/10/2007 04:36PM
Subject: Re: [Mifos-developer] Developer questions related to mifos
application(build issues)
Hi Amiruddin,
>- The build only runs ApplicationTestSuite testcases, as per my
understanding these testcases are related to the application behavior and does
not include test files which run database test. Am i going in right >direction
?
>So the idea is, why not run all the tests defined in the test source
folder ? If we dont make it part of build process developers working on it wont
even know when they broke the tests.
According to my knowledge, all test classes are called by
ApplicationTestSuite.java, including LatestTest .java (for the Database tests).
>- I tried running all the tests in the test folder as part of build
(had fileset with pattern defined as **/*Test.class), the build process took 40
mins to complete, also some of the tests were failing.
>So the first question is why are those tests failing, the second is
why is the build taking so long to complete. I have worked on projects with
many database tests but it never took me so long to build the >application, can
we have a look into that too.
Can you please send the tot al t ests that were failures (test log in
the ?TEST-org mifos application ApplicationTestSuite.xml? file)?
May be that these are problems related to your environment: the locale
from your machine or the time zone dependency?
(You can try setting your time zone to Pacific Time (GMT -8) and see if
the tests pass for you; it?s a possible that this solves the problem )
Cheers,
- Nazir
________________________________
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de
Amiruddin Nagri
Envoyé : lundi 10 décembre 2007 07:48
À : [email protected]
Objet : [Mifos-developer] Developer questions related to mifos
application(build issues)
Hi all,
I was going through the build process and there were some questions
that I would like to know more about, if someone can help me out in these areas
i can get ready to contribute to the project.
- The build only runs ApplicationTestSuite testcases, as per my
understanding these testcases are related to the application behavior and does
not include test files which run database test. Am i going in right direction ?
So the idea is, why not run all the tests defined in the test source
folder ? If we dont make it part of build process developers working on it wont
even know when they broke the tests.
- I tried running all the tests in the test folder as part of build
(had fileset with pattern defined as **/*Test.class), the build process took 40
mins to complete, also some of the tests were failing.
So the first question is why are those tests failing, the second is why
is the build taking so long to complete. I have worked on projects with many
database tests but it never took me so long to build the application, can we
have a look into that too.
Any inputs on these issues will help me get started and in general sort
out major roadblocks from developer contributing to the project.
Thanks and Regards,
Amiruddin Nagri,
ThoughtWorks Technologies India Pvt. Ltd.,
2nd Floor, Tower C, Diamond District, Airport road,
Bangalore, 560008, KA
India
Y! IM : [EMAIL PROTECTED]
GTalk : [EMAIL PROTECTED]
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
