Hi Saurabh, Thanks for the patch! I have reviewed this and functionally it looks like it addresses the issues 1354 and 1401 which is great. In reviewing the code, here is some feedback: In HolidayAction.java: * The methods "get" and "getHolidays" have large sections of repeated code. It also appears that the getHolidays method my not be called. Please either factor out the duplicated code into a separate method that can be shared.or remove the getHolidays method if you can confirm that it is unused. * When calling setCollectionAttribute to add attributes to the session, please define constants for the strings that are used for the attributes. String like "noOfYears", "year", aand "holidayList" should be added to the constants defined in HolidayConstants. These same constant values should be referenced from the jsp page. * A small point, but rather than using a variable like "i" in the loops in the methods get and getHolidays, try to use a more descriptive name along the lines of "yearGroupingCount" or some other descriptive name. Please resubmit after addressing the items above. Thanks, --Van ________________________________
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Saurabh Kumar Sent: Sunday, January 13, 2008 9:38 PM To: [email protected] Subject: [Mifos-developer] patch for defects 1354 and 1401 .... Hi All, Please find the patch for defects 1354 and 1401. 1354 >> Holidays scheduled over 3 years in advance don't display 1401 >> list of holidays should be sorted by date Thanks & Regards, Saurabh Kumar * Developer * SunGard * Offshore Services * Divyasree Chambers, Langford Road, Bangalore 560025 India Tel +91-80-2222-0501 * Mobile +91-9886945575 * Fax +91-80-2222-0511 * www.sungard.com <http://www.sungard.com/>
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
