Hi, Please find the patch for defects 1587 and 1590. Please note that apart from bug fixing I have removed some hard coding of strings from code. I have added constants for these strings in Constants.java file. 1587 >> Define Accepted payment methods not working for clients/groups https://mifos.dev.java.net/issues/show_bug.cgi?id=1587 1590 >> Define accepted payment methods not separated for savings deposits/withdrawals https://mifos.dev.java.net/issues/show_bug.cgi?id=1590 Suggestion >> I have noticed that at many places we are using hard coding for empty string and some common strings like "savings", "loan", etc. Also in getSecurity() method of all the action classes we are using hard coded values for strings like "load", "preview", "previous". We can move all these constants to Constants.java file or to the constants files of there respective modules. We can voluntarily take up this task while fixing bugs, i.e, while fixing bugs we can remove hard coding for common strings from the corresponding action classes. Thanks & Regards, P Think before you print Saurabh Kumar * Developer * SunGard * Technology Services * Divyasree Chambers, Langford Road, Bangalore 560025 India Tel +91-80-2222-0501 * Mobile +91-9886945575 * Fax +91-80-2222-0511 * <http://www.sungard.com/> www.sungard.com
patch_for_1587.patch
Description: patch_for_1587.patch
Description: patch_for_1590.patch------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
