Thank you Selim for your patches. I started reviewing the first one (#1446). Overall this patch looks good, However there's a feedback;
There is a need to write tests for method getPrdOfferingMix() in class PrdOfferingPersistenceTest and getPrdOfferingMix in class ProductMixBusinessServiceTest, to ensure their coverage. Looking forward to an updated patch. Thanks, - Nazir De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Selim Lachiheb Envoyé : jeudi 31 janvier 2008 15:53 À : [email protected] Objet : [Mifos-developer] Patchs for issue #1446 and issue #1447 Hi Nazir , Please find the 2 patchs for review related to : issue #1446 (https://mifos.dev.java.net/issues/show_bug.cgi?id=1446 <https://mifos.dev.java.net/issues/show_bug.cgi?id=1446> ) issue #1447 (https://mifos.dev.java.net/issues/show_bug.cgi?id=1447 <https://mifos.dev.java.net/issues/show_bug.cgi?id=1447> ) Please let me know if more information is required. Suggestions are welcome. With Regards, Selim _____________________________________________________________________ Selim LACHIHEB Software Developer OXIA OXIA is ISO 9001 V2000 certified company - AFAQ QUAL/2005/25140 11, Rue Claude Bernard 1002 Tunis Belvédère Tunisia Tel.: +216 71 28 27 00 Fax: +216 71 28 27 05 [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> www.oxiasoft.com <BLOCKED::http://www.oxiasoft.com/>
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
