Hi Nagesh, Thanks for the PMD setup patch. I have committed your most recent patch as revision 12308. Here is some feedback regarding small changes that have been integrated into the commit: * the build file has been renamed to build-pmd.xml to follow existing build file naming conventions * the build-pmd project name has been changed from mifos to mifos-pmd The jar files required by PMD have been included in the commit, so that the pmd build should be able to be run as is. We may not want to keep tool related jars like these in the repository, but instead have developers download them themselves. We can see if there is any discussion around this point. There is a PMD plugin for eclipse that could be useful if we begin having developers taking action on items flagged by PMD. It would be good to understand how to keep the rulesets used by the build and used by the Eclipse plugin in sync. For anyone interested, here is the link for IDE integration: http://pmd.sourceforge.net/integrations.html In looking through what is flagged by PMD, it seems that there will be a need for some ongoing discussion about which rules we would or would not want to apply to the Mifos project (for example, when/if a parameter name should be flagged as "too long"). The best time for detailed discussion about this will most likely be after the push for the 1.1 release. Cheers, --Van
________________________________ From: Nagesh Pulluru [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 29, 2008 9:54 AM To: Developer Cc: Massimiliano Parlione; [EMAIL PROTECTED]; Sam Birney; Van Mittal-Henkle; Ofer Matan Subject: Re: [Mifos-developer] PMD Integration with build. Importance: High Hi! Van, I have created another patch with some changes in the directory structure to squeeze and keep the directory structure tidy. I have changed the code in the pmdbuild.xml file and was able to generate the pmd reports with the new changes in the directory structure. I have also updated the documentation with these changes. Please review the document and the patch attached below and let us know your any ideas on it. FYI, I have removed the directories /tools, /pmd-xslt-files, and /reports from the root directory and have added a directory /pmd which contains another 3 directories /reports, /xslt, and /lib. Please see below for better understanding. pmd/ | lib/ reports/ xslt/ (PMD Jar Files) (PMD Reports) (xslt files) Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm "Van Mittal-Henkle" <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 29/01/2008 11:11 Please respond to Developer <[email protected]> To <[email protected]> cc Massimiliano Parlione/Ireland/[EMAIL PROTECTED], Nagesh Pulluru/Ireland/[EMAIL PROTECTED], Sam Birney <[EMAIL PROTECTED]> Subject Re: [Mifos-developer] PMD Integration with build. Hi Nagesh, Thanks for the patch. Looking in the patch file it only contains diffs for creating a "test_pmdbuild.xml". To evaluate what you've done create a new patch from the top level of the mifos project which includes all the files (including pmdbuild.xml) and directories mentioned in your document with the exception of the tools directory and its contents. Once this is done please put together a zip/gzip file that contains the necessary pmd files for the tools directory. The idea would be that with your patch plus the zip file for the tools directory, another developer should have everything they need to try running the pmd build target. Cheers, --Van ________________________________ From: Nagesh Pulluru [mailto:[EMAIL PROTECTED] Sent: Monday, January 28, 2008 2:13 AM To: [email protected] Cc: Massimiliano Parlione; Sam Birney; Van Mittal-Henkle; Ofer Matan Subject: RE: [Mifos-developer] PMD Integration with build. Importance: High Hi! Guys, Could any one of you please review the below Patch / Buildfile and the Documentation, and let us know if you find any problems in it. All the suggestions and comments are most welcome to improve the process. Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm Nagesh Pulluru/Ireland/IBM 23/01/2008 12:41 To "Ofer Matan" <[EMAIL PROTECTED]> cc Massimiliano Parlione/Ireland/[EMAIL PROTECTED], "'Sam Birney'" <[EMAIL PROTECTED]>, "'Van Mittal-Henkle'" <[EMAIL PROTECTED]> Subject RE: [Mifos-developer] PMD Integration with build.Link <Notes://d06ml901/80256D9C007BC87C/DABA975B9FB113EB852564B5001283EA/57A9 7395188772E9802573D8007F79B7> Hi! Ofer, Thanks for u r support.Thats correct, tools/pmd/ directory should be in the Mifos tree to run pmdbuild.xml, which contains the PMD jar files, as well as reports/pmd/ directory where the PMD Reports will be sotred and pmd-xslt-files/xslt/ which contains the xslt files to convert the xml output to html for getting a good layout. If we want to decrease the directories in the MIFOS Tree, we can avoid adding 3 different directories which we have now and may change as per the below structure. pmd/ | lib/ reports/ xslt/ (PMD Jar Files) (PMD Reports) (xslt files) Please let us know your idea? Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm "Ofer Matan" <[EMAIL PROTECTED]> 22/01/2008 23:1 To Nagesh Pulluru/Ireland/[EMAIL PROTECTED] cc Massimiliano Parlione/Ireland/[EMAIL PROTECTED], "'Sam Birney'" <[EMAIL PROTECTED]>, "'Van Mittal-Henkle'" <[EMAIL PROTECTED]> Subject RE: [Mifos-developer] PMD Integration with build. Nagesh, I plan to test putting this into a bamboo test environment for all to check. I'll keep you up to date. One aspect I wasn't sure about the design is that the pmd jars are assumed to be inside the Mifos tree in the tools directory, I assume that would require checking them in to svn. Is that correct ? Best, -Ofer From: Nagesh Pulluru [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 22, 2008 7:22 AM To: Ofer Matan Cc: Massimiliano Parlione Subject: Fw: [Mifos-developer] PMD Integration with build. Importance: High Hi! Ofer, How are you, could you please let us know if we can Integrate the file "pmdbuild.xml" with Bamboo and will this create any problems if we are not importing this file in the main build file "build.xml", because we are working in the other way now. Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm ----- Forwarded by Nagesh Pulluru/Ireland/IBM on 22/01/2008 15:16 ----- Nagesh Pulluru/Ireland/IBM 21/01/2008 17:35 To Developer <[email protected]> cc "Developer" <[email protected]>, [EMAIL PROTECTED], Massimiliano Parlione/Ireland/[EMAIL PROTECTED] Subject Re: [Mifos-developer] PMD Integration with build.Link <Notes://d06ml901/80256D9C007BC87C/DABA975B9FB113EB852564B5001283EA/BF34 1C3C4019231C802573D4000B6D85> Hi! Van, I have imported "build.xml" in the file "pmdbuild.xml" as you mentioned, and created a patch for "pmdbuild.xml". Please have a look at the patch and let us know if anything to be modified.We think it would be better if we add the "pmdbuild.xml" in the main file "build.xml". This approach will facilitate the Bamboo Integration by having Master build file that controls all the directories. PMD is an alternative tool for Checkstyle. I was not aware that we were suppose to use Checkstyle for Mifos, I think there is not much difference in PMD and Checkstyle. One main difference I found in the search is that " Checkstyle can also be configured to check for JavaDoc and code style conventions (like, does the braces appear on a new line vs the same line as the function, and so on.). But if code quality is the main goal then PMD will be suffice ", I think we can also try to create our own rulesets in PMD, may be we can find some of the important rulesets from Checkstyle and create it in PMD. Please let us know your idea? Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm "Van Mittal-Henkle" <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 18/01/2008 02:05 Please respond to Developer <[email protected]> To "Developer" <[email protected]> cc Subject Re: [Mifos-developer] PMD Integration with build. Hi Nagesh, The basic approach here looks good. Initially, I would suggest creating a new build file as you did and import the existing build file to pick up any common configuration entries. This is the approach taken with findbugs.xml, for example. Using this approach, entries that are specific to pmd would be kept in the pmdbuild.xml file. After we've gotten some experience using pmd on the project then we could consider whether we would gain by including it in the primary build file. As a note, in an earlier thread, it was suggested that a tool called CheckStyle be used to help enforce coding standards for Mifos. My understanding is that pmd is an alternative to using CheckStyle, is that correct? Cheers, --Van ________________________________ From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Nagesh Pulluru Sent: Wednesday, January 16, 2008 9:56 AM To: [email protected] Cc: Sam Birney Subject: [Mifos-developer] PMD Integration with build. Hi! Guys, I have added a build file named "pmdbuild.xml" which will generate the PMD reports for the java files. At present there is no reference to this pmdbuild.xml from build.xml, we are going to add the reference ASAP in build.xml. Please any one of you review the document and let us know if we need to add or modify any contents in it. Thanks in advance... With Regards, Nagesh Pulluru Process Engineer (MES / SG) IBM Technology Campus, Damastown Industrial Estate, Mulhuddart, Dublin-15, Ireland. Internal: 511493 Phone: +353-1- 8151493 Email: [EMAIL PROTECTED] IBM International Holdings BV registered in Ireland with number 903924. Registered office: Oldbrook House, 24-32 Pembroke Road, Ballsbridge, Dublin 4 http://gemfrv24.mul.ie.ibm.com/eng/process/proceng.htm------------------ ------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ------------------------------------------------------------------------ - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
