On Feb 15, 2:56 am, "Stephen Horgan" <[EMAIL PROTECTED]> wrote: > I've created a patch for issue 1635 and attached it to the issue tracker.
Thank you, Steve! We'll take a look at it. > In case anybody is interested, the original error was a > NotImplementedException when trying to attach a survey to a loan account. I > fixed this only to discover the next step in the process was also broken: a > NPE was thrown when submitting the answers to the survey. So I fixed this > too. Both problems were caused by incorrect URLs. > And finally when clicking the link to view a previously-taken survey, a > ClassCastException was thrown when executing a hibernate named query. This > is also now fixed. > > I'm not sure of the protocol in these cases; maybe I should have opened more > issues in the tracker? In the end I just fixed them all as part of issue > 1635 since they were functionally somewhat related. That sounds fine. If you ran into something completely unrelated to 1635 (especially if it fixes another extant bug) it would be good to create a separate patch and attach to the appropriate issue. > Finally, I included a selenium test that will verify the correction of all > three bugs. I'm a big fan of Selenium and have used it extensively in other > projects, so hopefully the Mifos project embraces the tool :-) Awesome! I'm assuming the following preconditions: * baseURL should be http://test.mifos.org:8085/ * this Mifos instance has the standard set of test data (whatever that means) I added the example to http://mifos.org/developers/wiki/SmokeTesting#examples -- Adam Monsen ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
