Hi Van, Thanks for applying the changes, and I hope to contribute more in future. I did notice one thing though, the latest-data.sql does not seem to have the DB changes for this feature, i.e. the database upgrade to 175, and the corresponding changes for the lookup values. I think you might have missed checking that in and I assume that is required if we do the "clean database" build.
Thanks Soham >-----Original Message----- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On >Behalf Of Van Mittal-Henkle >Sent: Friday, February 29, 2008 5:43 AM >To: Developer >Subject: Re: [Mifos-developer] PATCH: Declining Balance - >EqualPrincipalInstallments > >Hi Soham, > >> I am submitting a patch for the feature Declining Balance - Equal >> Principal Installments based on rev 12276 >> >http://www.mifos.org/developers/wiki/DecliningBalanceInterestCa >lculation >With >> EqualPrincipalInstallment > >Thanks for the patch! It has been committed as revision 12333. > >There will be some additional validation done by the Mifos >team, so we may have additional questions related to this, but >it looks good. > >> I tried to follow all the recommended steps, however this being my >> first attempt, please let me know if I missed anything and also >> provide feedback/suggestions. > >You've done a great job implementing this and providing good >test cases for it. Thank you for contributing a nice piece of >work to the Mifos project. Note that some changes were made >in order to commit it, but these had to do with changes which >occurred between when you submitted your patch and when we >were able to review it (e.g. Database version number changes). > >Cheers, >--Van > > > >--------------------------------------------------------------- >---------- >This SF.net email is sponsored by: Microsoft Defy all >challenges. Microsoft(R) Visual Studio 2008. >http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
