[
http://mifosforge.jira.com/browse/MIFOS-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on MIFOS-1543 started by Adam Monsen.
> replace custom Mifos StringUtils methods with library-provided methods
> ----------------------------------------------------------------------
>
> Key: MIFOS-1543
> URL: http://mifosforge.jira.com/browse/MIFOS-1543
> Project: mifos
> Issue Type: Improvement
> Components: Misc
> Affects Versions: Release 1.1
> Environment: Platform: All, OS: All
> Reporter: Adam Monsen
> Assignee: Adam Monsen
> Priority: Major
> Fix For: Gazelle Backlog
>
> Attachments: patch_1543
>
>
> Problem:
> 1. org.mifos.framework.util.helpers.StringUtils has many methods that
> can/should
> be replaced by 3rd-party-library-provided methods, like those in
> org.apache.commons.lang.StringUtils.
> 2. there are dangerously misnamed methods like isNullSafe(), which actually
> reports if a String is /not/ null
> Proposed solution:
> 1. remove lpad
> 2. replace references to lpad with calls to
> org.apache.commons.lang.StringUtils#leftPad
> 3. remove isNullSafe. Replace reference with inline null checks. A method is
> never necessary to check if an object reference is null.
> 4. remove isNullAndEmptySafe, isNullOrEmpty, isEmpty
> 5. replace references to isNullAndEmptySafe, isNullOrEmpty, isEmpty with
> corresponding methods in org.apache.commons.lang.StringUtils
> 6. move getMessageWithSubstitution and normalizeSearchString to another class
> 7. delete StringUtils class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
