[ http://mifosforge.jira.com/browse/MIFOS-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58178#action_58178 ]
Kay Chau edited comment on MIFOS-3002 at 6/10/10 2:06 PM: ---------------------------------------------------------- >From Keith we can add check to see if there is a difference is the holidays that apply when re-parenting the given office, if not then no problem, if there is, then we can 1) provide message and disallow 2) provide message and create batch job to handle this For this issue we will go with Option #1, and open an improvement for implementing option #2 in the future. Make sure there is only a message to disallow if there are holidays that could cause problems. A few scenarios Scenario 1 Hierarchy with HO > RO > BO. Where BO1 belongs to RO1 and user wants to move BO1 to RO2. There should only be a message if there are holidays attached to RO1 or RO2 in the future that BO1 needs to inherit. If HO has holidays that should not affect this as BO1 continues to be a child of HO. Scenario 2 Hierarchy .........HO ......../ \ .......A1 A2 ....../ \ .....R1 R2 ..../ ...B1 If we want to reparent B1 from R1 to R2, the following offices need to be considered for the error message - R1, A1, A2, and R2. If there are future holidays attached to HO that should not affect this. was (Author: kaychau): From Keith we can add check to see if there is a difference is the holidays that apply when re-parenting the given office, if not then no problem, if there is, then we can 1) provide message and disallow 2) provide message and create batch job to handle this For this issue we will go with Option #1, and open an improvement for implementing option #2 in the future. Make sure there is only a message to disallow if there are holidays that could cause problems. A few scenarios Scenario 1 Hierarchy with HO > RO > BO. Where BO1 belongs to RO1 and user wants to move BO1 to RO2. There should only be a message if there are holidays attached to RO1 or RO2 in the future that BO1 needs to inherit. If HO has holidays that should not affect this as BO1 continues to be a child of HO. Scenario 2 Hierarchy HO / \ A1 A2 / \ R1 R2 / B1 If we want to reparent B1 from R1 to R2, the following offices need to be considered for the error message - R1, A1, A2, and R2. If there are future holidays attached to HO that should not affect this. > Add warning message for holidays when user changes parent of office or office > type > ---------------------------------------------------------------------------------- > > Key: MIFOS-3002 > URL: http://mifosforge.jira.com/browse/MIFOS-3002 > Project: mifos > Issue Type: Bug > Components: Office > Affects Versions: Shamim D > Reporter: Kay Chau > Assignee: keithwoodlock > Fix For: Shamim D > > > With the addition of branch level holidays, if a user changes the parent of > an office in the office hierarchy, there might not be desired behavior around > holidays and schedules. Ultimately we want to fix this to work properly, but > since this is an edge case, let's add a warning message for now > Go to Admin > View Offices. click on an office, and click edit office > information. > Only add a warning message if the current office you are editing and any of > its parents have a holiday in the future, or if the parent you are changing > to have future holidays. > Also add a warning message if you are changing the office type and you have > future holidays associated with your office. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://mifosforge.jira.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Mifos-issues mailing list Mifos-issues@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mifos-issues