[
http://mifosforge.jira.com/browse/MIFOS-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60671#action_60671
]
Adam Monsen commented on MIFOS-3499:
------------------------------------
Sorry, we can't accept a patch without a passing build.
FWIW, I applied your patch to the 1.7.x branch and tried "mvn clean install" on
my box. I got a failure in AdditionalHolidayTest.
Here's acceptanceTests/target/surefire-reports/TestSuite.txt:
{noformat}
-------------------------------------------------------------------------------
Test set: TestSuite
-------------------------------------------------------------------------------
Tests run: 70, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 572.542 sec
<<< FAILURE!
testMoratoriumPushesSavingsPaymentsToFuture(org.mifos.test.acceptance.holiday.AdditionalHolidayTest)
Time elapsed: 12.281 sec <<< FAILURE!
com.thoughtworks.selenium.SeleniumException: ERROR: Element
homeheader.link.clientsAndAccounts not found
at
com.thoughtworks.selenium.HttpCommandProcessor.throwAssertionFailureExceptionOrError(HttpCommandProcessor.java:97)
at
com.thoughtworks.selenium.HttpCommandProcessor.doCommand(HttpCommandProcessor.java:91)
at
com.thoughtworks.selenium.DefaultSelenium.click(DefaultSelenium.java:167)
at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at
org.springframework.aop.aspectj.AspectJAfterAdvice.invoke(AspectJAfterAdvice.java:42)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
at $Proxy16.click(Unknown Source)
at
org.mifos.test.acceptance.framework.HomePage.navigateToClientsAndAccountsUsingHeaderTab(HomePage.java:52)
at
org.mifos.test.acceptance.holiday.AdditionalHolidayTest.loginAndNavigatetoClientsAndAccountsHomepage(AdditionalHolidayTest.java:787)
at
org.mifos.test.acceptance.holiday.AdditionalHolidayTest.testMoratoriumPushesSavingsPaymentsToFuture(AdditionalHolidayTest.java:578)
{noformat}
> If user does not have right to create a group, Mifos throws a NPE instead of
> a permission error
> -----------------------------------------------------------------------------------------------
>
> Key: MIFOS-3499
> URL: http://mifosforge.jira.com/browse/MIFOS-3499
> Project: mifos
> Issue Type: Bug
> Components: Roles and Permission
> Affects Versions: Release 1.6.0
> Reporter: Ryan Whitney
> Assignee: Narcisa Pantilimon
> Fix For: Release E, Unscheduled
>
> Attachments:
> 0001-Message-error-when-no-permissions-to-add-group.patch, MIFOS 3499 -
> Error.txt
>
>
> If the user does not have the Group permission "Can create new group in
> submit for approval state" and tries to create a group, when they click on
> "Submit for Approval", mifos throws a NPE instead of a permissions error.
> REPRO:
> You can see this on demo.mifos.org
> user: baatest
> passwd: mifostest
> 1. Find a center in Pasay Branch
> 2. Click on Add Group
> 3. Enter in information and click on preview
> 4. Click on Submit for Approval
> EXPECTED:
> Mifos displays an error stating the user doesn't have permission for the
> action
> ACTUAL:
> Mifos throws a NPE
> Error attached
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
