Batch job execution should use Date from 
org.mifos.framework.components.batchjobs.TaskHelper.execute(long timeInMillis) 
, Not the system date
---------------------------------------------------------------------------------------------------------------------------------------------

                 Key: MIFOS-4082
                 URL: http://mifosforge.jira.com/browse/MIFOS-4082
             Project: mifos
          Issue Type: Improvement
          Components: Batch jobs
    Affects Versions: Release E
            Reporter: Udai Gupta
            Assignee: mifosdeveloperqueue
            Priority: Major
             Fix For: Unscheduled


ApplyHolidayChangesHelper uses the system date which will cause problem during 
catch up mechanism (after failure rerun next day).

long taskStartTime = new DateTimeService().getCurrentDateTime().getMillis();

Is it intentional?

org.mifos.framework.components.batchjobs.TaskHelper.execute(long timeInMillis), 
argument is passed in a catchup execution from jobParameter date is going to be 
the date on which the batch job was failure (or haven't ran). If this argument 
is not used correctly then there will be no effect of catchup mechanism.

to understand what Job Instance, Job execution and Job Parameter means read
http://static.springsource.org/spring-batch/reference/html/domain.html

We don't know the severity of this issue? 

Previously people used to catchup batch jobs by rerunning them after moving the 
system date.

There is no change as it was the behaviour of Mifos Batch Jobs before 
Spring/Quartz implementation.

There is more to investigate here than to implement

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Achieve Improved Network Security with IP and DNS Reputation.
Defend against bad network traffic, including botnets, malware, 
phishing sites, and compromised hosts - saving your company time, 
money, and embarrassment.   Learn More! 
http://p.sf.net/sfu/hpdev2dev-nov
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to