[ 
http://mifosforge.jira.com/browse/MIFOS-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61472#action_61472
 ] 

Udai Gupta commented on MIFOS-4031:
-----------------------------------

As far as this particular upgrade goes, we can agree that autocommit should not 
be turned on. But it's also turning off the autocommit at the end and that's 
why this upgrade is not going to affect other upgrades.

I can also say that if Mifos upgrade fails then it's always going to leave 
database in inconsistent state for multiple DDL statements in one upgrade.
http://dev.mysql.com/doc/refman/5.0/en/cannot-roll-back.html
So, every statement which can't be rollback should be a separate upgrade.

eg.
upgrade12.sql
alter abc
alter xyz

can be in same upgrade while to maintain consistency of rollback we should 
follow a thumb rule that these statements will be a separate upgrade.

upgrade1.sql
alter abc 
upgrade2.sql
alter xyz


> Upgrade1277565300 turns autocommit on.  Autocommit should not be used in DB 
> upgrades since a failure in the middle of the upgrade will leave the db in an 
> inconsistent state.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MIFOS-4031
>                 URL: http://mifosforge.jira.com/browse/MIFOS-4031
>             Project: mifos
>          Issue Type: Bug
>    Affects Versions: Release E
>            Reporter: Van Mittal-Henkle
>            Assignee: mifosdeveloperqueue
>            Priority: Major
>             Fix For: Release E - Iteration 10, Release E
>
>
> Each database upgrade should be in a single transaction so if any part of the 
> upgrade fails then the whole upgrade will fail.  When autocommit is on, if 
> the upgrade fails partway through, then the db will be left in an 
> inconsistent state.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to