Technical Improvement: ApplicationException & subclasses shouldn't use String
key, but Enum
-------------------------------------------------------------------------------------------
Key: MIFOS-4417
URL: http://mifosforge.jira.com/browse/MIFOS-4417
Project: mifos
Issue Type: Improvement
Reporter: Michael Vorburger
While doing MIFOS-4416, and looking into ApplicationException & subclasses,
I've seen that sometimes the key is an actual message key (as String!), but
sometimes it's message string (String internalMessage), and somehow didn't find
that very clear - probably historically grown?
IMHO a better alternative would be to instead of String key have an (real,
Java) enum for the allowed message keys, à la FinancialExceptionConstants.
Those enums could be defined inside the respective Exception class, no need for
a separate *ExceptionConstants. The constructor would then take such an enum
type as message key, instead of String - and a String internalMessage.
I would suggest that a FinancialException(String message) constructor should
also be provided - for exceptions where a message key has not (yet) been
defined.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
