[
http://mifosforge.jira.com/browse/MIFOS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=64872#comment-64872
]
Adam Monsen edited comment on MIFOS-4112 at 2/14/11 11:38 AM:
--------------------------------------------------------------
Patch rejected.
I don't want to add 90 or so bogus messages... these will just confuse and
annoy translators. Will you look for a more elegant solution?
Have you looked at implementing {{org.springframework.validation.Validator}}?
...whoops, never mind about that, I just glanced at the work log for this issue
and it sounds like you probably already looked into Validator and such in more
depth than I. So, here's what I'd like to resolve with respect to this patch:
# Don't add bogus messages
#* idea: restrict them to a different, ugly message bundle (one that will not
be visible on translatewiki.net)
Also, a comment on the Selenium test... ad-hoc testing is sometimes fine, but
check with someone in QA first (like Jeff Brewster), ideally on the dev list.
Generally an automated test is preferable, and at the lowest (unit=low /
integration=medium / acceptance=high) level possible.
was (Author: meonkeys):
Patch rejected.
I don't want to add 90 or so bogus messages... these will just confuse and
annoy translators. Will you look for a more elegant solution?
Have you looked at implementing {{org.springframework.validation.Validator}}?
Also, a comment on the Selenium test... ad-hoc testing is sometimes fine, but
check with someone in QA first (like Jeff Brewster), ideally on the dev list.
Generally an automated test is preferable, and at the lowest (unit=low /
integration=medium / acceptance=high) level possible.
> Resolving MIFOS-3859 exposed a bug where typeMismatch.* error messages do not
> display correctly
> -----------------------------------------------------------------------------------------------
>
> Key: MIFOS-4112
> URL: http://mifosforge.jira.com/browse/MIFOS-4112
> Project: mifos
> Issue Type: Bug
> Components: Loan Account
> Reporter: jasmine sandhu
> Assignee: jasmine sandhu
> Labels: volunteer
> Fix For: Mifos Backlog
>
> Attachments:
> 0001-MIFOS-4112-fixed-the-display-of-the-error-messages-t.patch,
> defineLoanProducts-test.html, typeMismatchError_after3859.png,
> typeMismatchError_after3859.png, typeMismatchErrorOnCI_oldCode.png,
> typeMismatchErrorOnCI_oldCode.png
>
> Time Spent: 1 week, 3 days, 2 hours
> Remaining Estimate: 0 minutes
>
> In fixing: http://mifosforge.jira.com/browse/MIFOS-3859
> the error messages displayed when the defineLoanProducts.flt form is
> incorrectly filled are validated by LoanProductFormBeanValidator.java. This
> class constructs the keys for the messages based on the constraint violation,
> so if the field is null, it constructs a message as:
> NotNull.loanProduct.*
> This message is then read from messages.properties. The messages of the form:
> typeMismatch.loanProduct.* are not being displayed correctly after this
> parameterization.
> As an example, if I enter a string for the first entry in the Last Loan
> Amount table, it should trigger a typeMismatch error (see attached images).
> In the previous version, it appears the typeMismatch.* key was not being
> read, but the error was nicer in that it displayed:
> Invalid data
> Now, with the update, the error reads the string from the key but does not
> replace the parameter correctly. So it shows up as:
> Please Specify the valid Start Range Loan Amount for by last loan at row
> loanAmountByLastLoanAmount[0].lower
> but it should show up as follows if the error occurred on row 1:
> Please Specify the valid Start Range Loan Amount for by last loan at row 1.
> The commit for Mifos-3859 is: 7d543c9621afadd7754e72b83401678b0bf410ca
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
