[ 
http://mifosforge.jira.com/browse/MIFOS-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

keithwoodlock resolved MIFOS-4655.
----------------------------------

    Resolution: Won't Fix

> TECHDEBT: layering: Remove persistence usage from ClientBO
> ----------------------------------------------------------
>
>                 Key: MIFOS-4655
>                 URL: http://mifosforge.jira.com/browse/MIFOS-4655
>             Project: mifos
>          Issue Type: Story
>    Affects Versions: Release 1.6.0, Release 1.6.1, Release 2.0.0, Release 
> 1.6.2, Release 2.0.1, Release 2.1
>            Reporter: keithwoodlock
>            Assignee: mifosdeveloperqueue
>              Labels: layering, techdebt
>             Fix For: Unscheduled
>
>
> ClientBO
> Pros:
>    #. static factory methods in place and used by application code
>    #. Builder exists for creation of ClientBO
> Cons:
>    #. extends customer (too much behaviour leaked into customer from other 
> sub classes group/client that is not relevant)
>    #. deprecated constructors still exists but only used by test 
> infrastructure. 
>        - as a result, there is good deal of code used only from deprecated 
> constructors..
> Notes:
>    #. Clients can be created in lots of states.
>    #. customer account always created with client - probably makes sense abit 
> for clients.
>    #. behaviour seems to be updatePerformaceHistoryOnXXX, validation and 
> behaviour around checking states, family details, savings, attendance?
> This story is about removing persistence responsibilities from ClientBO which 
> means:
>     * remove ClientBOIntegrationTest and have only unit tests around ClientBO
>     * remove use of deprecated constructors used only in integration tests
>     * requires removal of where TestObjectFactory.createClient is used
>     * replace with use of Builder + 
> IntegrationTestObjectMother.createClient(XXX)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to