[
http://mifosforge.jira.com/browse/MIFOS-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Chudy updated MIFOS-4417:
--------------------------------
Priority: Trivial (was: Minor)
> Technical Improvement: ApplicationException & subclasses shouldn't use String
> key, but Enum
> -------------------------------------------------------------------------------------------
>
> Key: MIFOS-4417
> URL: http://mifosforge.jira.com/browse/MIFOS-4417
> Project: mifos
> Issue Type: Improvement
> Components: Technical Discussion
> Reporter: Michael Vorburger
> Assignee: mifosdeveloperqueue
> Priority: Trivial
> Fix For: Unscheduled
>
>
> While doing MIFOS-4416, and looking into ApplicationException & subclasses,
> I've seen that sometimes the key is an actual message key (as String!), but
> sometimes it's message string (String internalMessage), and somehow didn't
> find that very clear - probably historically grown?
> IMHO a better alternative would be to instead of String key have an (real,
> Java) enum for the allowed message keys, à la FinancialExceptionConstants.
> Those enums could be defined inside the respective Exception class, no need
> for a separate *ExceptionConstants. The constructor would then take such an
> enum type as message key, instead of String - and a String internalMessage.
> I would suggest that a FinancialException(String message) constructor should
> also be provided - for exceptions where a message key has not (yet) been
> defined.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
