Dear Jakub,
How to do that?
sorry was out 1 week. and just saw your message.
Thanks for your comment.
George
On 12/5/2011 3:33 PM, Jakub Sławiński wrote:
Hi,
is anyone looking at the test failures that appeared after applying this
patch?
Regards,
Jakub.
On 12/04/2011 07:58 PM, Keith Woodlock wrote:
Jasmine,
Thanks for the patch.
It applied cleanly and I launched application to inspect changes. As
you have noted the currency in mifos is set in 'configuration' and its
also possible to have 'multiple currencies' where one specific
currency is selected from the 'loan product'. So currency isnt related
to 'user locale' e.g. if i which my preferred locale to spanish, the
currency shouldnt switch to 'euro' etc.
So for now, its enough to just use type="number" for displaying
numbers in mifos.
Thanks again,
Keith.
On Sun, Dec 4, 2011 at 6:41 AM, Jasmine Sandhu<[email protected]> wrote:
For LoanProductDetails.jsp I used type="currency" and it shows up as
pounds because I guess the locale is GB_En. For the other pages I simply
used type="number".
I tested it against the 3 options for calculating the loans and
installments and things looked fine.
From Udai's comment about not supporting localization for numbers, I suppose
all these should be type="number". Is that correct?
It is easier to set them all the "number" than to figure out which ones are
"currency" but I had already done this one so figured I'd leave it and ask
what is desirable. I suppose we probably use mifos in the english language
for a lot of countries outside the UK so perhaps type should be number as
opposed to currency otherwise the amounts will show up with the pound
symbol. Better to ask how it should be rather than to make my own
presumptions and assumptions, let me know and I'll fix and provide a new
patch.
On Sat, Dec 3, 2011 at 10:25 PM, Jasmine Sandhu<[email protected]>
wrote:
Hi All,
I was revisiting this today and ran into this same problem for the
collectionsheetentry pages as Andrew mentioned. That's definitely trickier.
However, I did find that I could update 3 of the JSP pages that handle
previewing of loan product data: CreateLoanProductPreview.jsp,
EditLoanProductPreview.jsp, LoanProductDetails.jsp.
Attached is the patch for these - it is generated against the g-release
branch.
With this patch, thousand separators show up correctly for following
cases:
(1) previewing the loan after a new loan is defined
(2) previewing the loan if an existing loan is edited.
(3) when viewing the details of an existing loan product
For LoanProductDetails.jsp I used type="currency" and it shows up as
pounds because I guess the locale is GB_En. For the other pages I simply
used type="number".
I tested it against the 3 options for calculating the loans and
installments and things looked fine.
<Andrew> Your videos for setting up mifos dev environment with all the
steps were incredibly helpful - great work! I was up and going in 1 evening.
You asked about how one knows the JSP pages associated with the URL. The
legacy mifos code used Struts for the framework and JSP for the views. The
framework config files define how the controllers are hooked up to the
views. These config files are located under:
head/application/src/main/resources/META-INF/resources/WEB-INF/*struts*.xml
They define which jsp pages are displayed based on the URL. As an example,
check out the productdefinition-structs-config.xml which shows the actions
(view pages) associated with /loanproductaction.do?...
That's my rough understanding of it, here's more info:
http://struts.apache.org/1.x/faqs/works.html
Regards,
Jasmine
On Fri, Nov 25, 2011 at 10:40 AM, Andrew Hagner<[email protected]>
wrote:
All,
While Jon's been working on the .ftl pages and formatting the input, I've
still been looking at the .jsp pages and how to fix inputting& displaying
commas on those.
At least for the 'Enter Collection Sheet Data' process, the input
elements call numbersOnly(this,event) which only lets you enter numerical
values for them. Altering that function to allow commas should partially fix
the issue. I'll then need to find where the values are submitted and make
sure the commas are stripped away before being processed.
Next, in order to display them correctly, like on the preview pages, I
believe its just a matter of modifying the Money class's toString() method,
so that it formats the value based on locale. I didn't see a way to do
formatting for these values right in the .jsp because of how the pages are
generated. If there is a way, please point it out to me, but from what I
looked over in the following files, the numbers come right from the
Money.class rather than a variable that can be formatted in a .jsp.
See:
BulkEntry_preview.jsp - Lines 201-205
BulkEntryTag.java and BulkEntryTagUIHelper.java and
BulkEntryDisplayHelper.java
Money.java - Lines 256-270, particularly Line 262
I'll be working on it for about 2-3 more hours today, mainly messing with
the Money.toString() method to see what I can do.
- Andrew
On Fri, Nov 18, 2011 at 11:41 AM, bankadmin<[email protected]> wrote:
Thank you very mach Jakub, Keith and Andrew,
Just to clarify: typical International or English (US or UK does not
matter ) standard will be OK for now.
We just want to see: 123,123,123.12 ( or 123,123,123)
instead of : 123123123.12 ( or 123123123)
George
On 11/18/2011 8:20 PM, Keith Woodlock wrote:
Andrew,
I guess the advantage of the approach that jakub said (using jsp tag
lig) is that you should get that for free.
solving it for display is first step, then you can step on and make
sure it works for input fields (although i never enter commas when
typing out a number!)
keith.
On Fri, Nov 18, 2011 at 2:36 PM, Andrew Hagner<[email protected]>
wrote:
Keith,
Thanks for the help! I realized that yesterday although a bit late
to help
me out much. As for the locales, is there a list somewhere of how
each
locale's currency should be formatted in terms of commas, decimals,
etc...?
If not I can try to put one together. And there is a variable/setting
in
Mifos that holds the locale, correct? So it would/should just be a
matter of
having a set of rules for formatting that corresponds to which
locale/currency is in use.
- Andrew
On Thu, Nov 17, 2011 at 6:06 PM, Keith
Woodlock<[email protected]>
wrote:
Andrew,
Whatever approach you use whether its the simple<fmt:formatNumber
value="${variable}" type="number" /> indicated by Jakub or the
JQuery
approach indicated by Udai, it has to be able to work for different
'locales', so no hard coding to any praticular number format
(english/american/ etc)
Keith.
On Thu, Nov 17, 2011 at 9:11 PM, Andrew Hagner<[email protected]>
wrote:
Binny& George,
Unfortunately things are taking me longer than expected so I
probably
won't
have the chance to get a working patch/page to you today. I'll let
you
know
as soon as we have something.
Also a quick question, I noticed that Udai's example
(http://www.apnapaisa.com/loan/home-loan-india/comparison.html)
puts
commas
every 2 decimal places, it that how you want it to work? I just
want to
make
sure, I'm used to doing every 3 decimal places so its just
something new
to
me.
Andrew
On Thu, Nov 17, 2011 at 3:07 PM, Andrew
Hagner<[email protected]>
wrote:
All,
If anyone could help me find the jsp page that goes with the
collection
sheet entry page& the preview page for collection sheet entry
that
would be
a big help. I can't seem to pinpoint that exact file, which is
where
the
formatting would be as well.
Also, Jon T. managed to get an input plugin running however he had
some
trouble creating a patch, and when tested on my version it didn't
quite
work. He won't be able to look at it again until this weekend,
sorry.
On Thu, Nov 17, 2011 at 1:29 PM, bankadmin<[email protected]>
wrote:
Thanks Jasmine. We are looking forward to Andrew's e-mail. He
promised
us at least 1 page today.
George
On 11/17/2011 9:15 PM, Jasmine sandhu wrote:
George,
I have not had a chance to do any work on this issue. Apologies
for
that,
but just don't have the time right now. I'll post if I make any
progress.
Jasmine
On Thu, Nov 17, 2011 at 6:31 AM, Andrew
Hagner<[email protected]>
wrote:
George,
I'm not sure how far Jasmine has got, but I should be able to
give
you
at least one page done by the end of today.
Andrew
On Thu, Nov 17, 2011 at 6:13 AM, George
IBERIA<[email protected]>
wrote:
Dear Andrew& Jasmine,
Any updated on this issue? Could you please give us even 1 page
with
the changes and explain the task? is it possible for 20%
techies to
do
those changes? ( without IDE) ?
Thanks and sorry for asking this .... just trying to prepare
nice
presentation for potential client.
george
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application
performance,
security threats, fraudulent activity, and more. Splunk takes
this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
Andrew Hagner
B.S. Software Engineering
Drexel University, Class of 2015
[email protected]
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application
performance,
security threats, fraudulent activity, and more. Splunk takes
this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
- Climbed Rainier to Raise funds for Asha - please sponsor my
climb -
-------------------------------------------------------------------------------------
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application
performance,
security threats, fraudulent activity, and more. Splunk takes
this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application
performance,
security threats, fraudulent activity, and more. Splunk takes
this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
Andrew Hagner
B.S. Software Engineering
Drexel University, Class of 2015
[email protected]
--
Andrew Hagner
B.S. Software Engineering
Drexel University, Class of 2015
[email protected]
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
Andrew Hagner
B.S. Software Engineering
Drexel University, Class of 2015
[email protected]
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
Andrew Hagner
B.S. Software Engineering
Drexel University, Class of 2015
[email protected]
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
- Climbed Rainier to Raise funds for Asha - please sponsor my climb -
-------------------------------------------------------------------------------------
--
- Climbed Rainier to Raise funds for Asha - please sponsor my climb -
-------------------------------------------------------------------------------------
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
Mifos-developer mailing list
[email protected]
Unsubscribe or change settings at:
https://lists.sourceforge.net/lists/listinfo/mifos-developer
--
You received this message because you are subscribed to the Google Groups "Mifos
Developer" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/mifosdeveloper?hl=en.
