Sarah, > 1) Do the folks with commit rights prefer volunteers to bunch up a whole lot > of little (unrelated) small commits, and submit 1 pull request to cover them > all? (Clearly, with comments/descriptions as appropriate!) ... or just do > them in bits and pieces, 1 request per fix? Never having used Github before > Mifos, I'm just eager that I'm following a norm, I guess.
I think in general its best that a commit is as small as possible but should be complete. If its a bug fix it should be everything thats need to fix the bug. If its a feature, theres likely to be more work but should still be all committed together. In either case its possible you 'committed' serveral times in your forked or local reposistory. If you work in a branch its possible to squash all these commits into one before merging into your version of master that you would do a pull request from. > 2) After my first pull request was submitted with a couple of easy bug > fixes, it sat around for a while... but as soon as I added a comment on JIRA > mentioning it was Pending, Jakub accepted them within a couple of days. Is > that helpful, or annoying, to have these types of comments added, to update > the issue in JIRA? I am not sure if notifications are set up to notify people that pull requests have been sent. Clearly JIRA is one way of getting peoples attention, or email or skype/irc. Keith. On Thu, May 10, 2012 at 9:23 PM, Sarah Farrier <[email protected]> wrote: > On Thu, Apr 12, 2012 at 9:06 PM, Sarah Farrier wrote: >> Mifos code-base for some time now, and have started to help on the JIRA >> issues list / sent in my first Github pull request already) > > Hi all, > > There was an additional thing I've been meaning to ask the dev list for some > time now - and that is the project team's preferred method of organising > pull requests from github forks? > > The official documentation covering this theme > (http://mifosforge.jira.com/wiki/display/MIFOS/Code+Submission+Process) is > quite out of date, so I suppose my questions are, more specifically: > > 1) Do the folks with commit rights prefer volunteers to bunch up a whole lot > of little (unrelated) small commits, and submit 1 pull request to cover them > all? (Clearly, with comments/descriptions as appropriate!) ... or just do > them in bits and pieces, 1 request per fix? Never having used Github before > Mifos, I'm just eager that I'm following a norm, I guess. > > 2) After my first pull request was submitted with a couple of easy bug > fixes, it sat around for a while... but as soon as I added a comment on JIRA > mentioning it was Pending, Jakub accepted them within a couple of days. Is > that helpful, or annoying, to have these types of comments added, to update > the issue in JIRA? > > 3) Unrelated to code submission... but whilst I remember - I've never > submitted a "Contributor Agreement" > (http://mifos.org/contributors/fine-print/contribuor-agreement/ - leads to a > 404)... I assume this is not a big concern? I do recall reading (on the > wiki?) that this had been pulled for a specific reason... to be updated...? > Anyway, I figure if there's a problem with my lack of filling in an > agreement, someone will give me a suitable nudge! =) > > Thanks, > Sarah Farrier. > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > Mifos-developer mailing list > [email protected] > Unsubscribe or change settings at: > https://lists.sourceforge.net/lists/listinfo/mifos-developer -- You received this message because you are subscribed to the Google Groups "Mifos Developer" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/mifosdeveloper?hl=en.
