Now that you mentioned it Robert, maybe the StorageProvider parameter should have also gone into MimeEntityConfig instead. Would it be worth to change that?
And another small idea: MimeEntityConfig could "return this" in all setters to make it easier to modify several properties at once.. Markus On Sat, Apr 18, 2009 at 8:48 PM, Markus Wiederkehr (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/MIME4J-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700526#action_12700526 > ] > > Markus Wiederkehr commented on MIME4J-128: > ------------------------------------------ > > The patch looks good but like Robert suggested I would prefer an additional > property in MimeEntityConfig instead of adding another constructor. > >> Make o.a.j.m.message.Message and o.a.j.m.parser.MimeStreamParser be able to >> do headless parsing by using o.a.j.m.parser.MimeTokenStream.parseHeadless >> ----------------------------------------------------------------------------------------------------------------------------------------------------- >> >> Key: MIME4J-128 >> URL: https://issues.apache.org/jira/browse/MIME4J-128 >> Project: JAMES Mime4j >> Issue Type: New Feature >> Affects Versions: 0.6 >> Environment: Mime4j 0.6, Http Servlet >> Reporter: Attila Király >> Assignee: Robert Burrell Donkin >> Fix For: 0.7 >> >> Attachments: message_headless_parse.patch >> >> >> parser.MimeTokenStream has a method called parseHeadless which makes it >> possible to parse MIME messages without header (which is the case for >> example in a web application with an incoming http request). This function >> is however not available in higher level apis of Mime4j like in >> parser.MimeStreamParser and message.Message. It would be nice to use it >> trough Message because so other functions of mime4j would be available, like >> the temporary storage. >> I made a small patch that makes it possible to configure and use >> message.Message and parser.MimeStreamParser so it will do a headless parse. >> The patch only adds functionality it does not modify the current behaviour >> of the classes. >> The patch contains modifications for message.Message (adding 2 new >> constructors) and parser.MimeStreamParser (adding a new function >> parseHeadless) and a test case for the headless parsing. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
