Look great. Thanks, Kai
2014-06-25 23:22 GMT+02:00 André Hentschel <n...@dawncrow.de>: > Am 24.06.2014 22:28, schrieb Kai Tietz: >> 2014-06-22 14:38 GMT+02:00 André Hentschel <n...@dawncrow.de>: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Am 21.06.2014 22:06, schrieb Kai Tietz: >>>> 2014-06-21 18:10 GMT+02:00 André Hentschel <n...@dawncrow.de>: >>>>> Am 21.06.2014 17:10, schrieb André Hentschel: >>>>>> Hi, >>>>>> this time i just put some commits on github for review [1], >>>>>> so please review, then i'll commit it except of the temporary tests. >>>>>> (btw, this is the work of more than two weeks...) >>>>>> >>>>>> [1] https://github.com/AndreRH/mingw-w64/commits/master >>>>>> >>>>> >>>>> Here it is as patch (without Makefile.in) >>>> >>>> Patch is ok. Only thing we might want to change here is softfloat.c. >>>> I don't think we should have one file implementing many math functions >>>> without need. So functions, which can go into own files, should be >>>> isolated, and it might be of interest to make out of softfloat.c >>>> instead an include file. >>> >>> 1) Why is it so bad to have all in one file? >> Because that reasons to link all functions into binary at once. >> Without LTO you get a lot of stuff you might not need into your >> executable. >>> 2) How do you want it exactly? sin.def.h and so on? which functions could >>> stay in softfloat.c? >> Well, something like implementation file. I wouldn't name them .h. >> Call them sin.c ... which includes the shared stuff from (best static >> or inline) softfloat.h. The none-inline version of those shared >> function could be placed into softfloat.c. >> >> Kai > > OK, how is that? > > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
