OK, I pushed it with "extern inline" declaration. Thanks for reviews, Jacek
On 08/19/14 15:38, Kai Tietz wrote: > Hmm, this patch looks to me not 100% ok. > > Making functions static inline seems to be not the proper thing to do > here AFAICS. This will lead to warning for cases those functions > aren't used. So I would think that attribute unused is missing here. > Additionally the 'inline' looks to me bogus. Either it should be > "extern inline", or static with attribute unused. > > Kai > > 2014-08-19 14:02 GMT+02:00 Jacek Caban <ja...@codeweavers.com>: >> --- >> mingw-w64-headers/crt/sec_api/string_s.h | 3 +++ >> mingw-w64-headers/crt/sec_api/wchar_s.h | 3 +++ >> 2 files changed, 6 insertions(+) >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Mingw-w64-public mailing list >> Mingw-w64-public@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > ------------------------------------------------------------------------------ > _______________________________________________ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ------------------------------------------------------------------------------ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
