On Wed, May 13, 2015 at 11:21 PM, Kai Tietz <ktiet...@googlemail.com> wrote:
> Hi,
>
> the same applies as for the other patch.  Just one comment I see about
> this idl-file (it isn't necessary to attach generated header to
> patch).  It seems to me that a lot of stuff is missing here.  On quick
> research I miss a lot of required interfaces, and some types.

Yes, I only added the interface I needed.

At least the generated .h file has something like
__IDXGIDebug_FWD_DEFINED__ (also present in the MS headers). So it's
possible to detect if some parts of headers are missing.
Also since d3d11.idl is missing some interfaces, I assume it's ok to
define IDL files with only a partial set of interfaces.

In general I find the whole process awkward. Wine should only add IDL
definitions when the classes are supported. Otherwise they just add
entry points that are not working. On the other hand mingw should not
have such requirements since the goal is to run on a functional
Windows. But it seems it's tied to Wine for definitions.

> Anyway, let us way for Wine's review on this.
>
> Regards,
> Kai
>
> 2015-05-12 16:40 GMT+02:00 Steve Lhomme <rob...@videolabs.io>:
>> ---
>>  mingw-w64-headers/Makefile.am                    |  1 +
>>  mingw-w64-headers/Makefile.in                    |  1 +
>>  mingw-w64-headers/direct-x/include/dxgidebug.idl | 44 
>> ++++++++++++++++++++++++
>>  3 files changed, 46 insertions(+)
>>  create mode 100644 mingw-w64-headers/direct-x/include/dxgidebug.idl
>>
>> diff --git a/mingw-w64-headers/Makefile.am b/mingw-w64-headers/Makefile.am
>> index a8f0990..09e8ad7 100644
>> --- a/mingw-w64-headers/Makefile.am
>> +++ b/mingw-w64-headers/Makefile.am
>> @@ -82,6 +82,7 @@ IDL_SRCS = \
>>    include/devicetopology.idl \
>>    include/downloadmgr.idl \
>>    include/dxva2api.idl \
>> +  include/dxgidebug.idl \
>>    include/endpointvolume.idl \
>>    include/exdisp.idl \
>>    include/filter.idl \
>> diff --git a/mingw-w64-headers/Makefile.in b/mingw-w64-headers/Makefile.in
>> index 901ff18..0cd19ce 100644
>> --- a/mingw-w64-headers/Makefile.in
>> +++ b/mingw-w64-headers/Makefile.in
>> @@ -306,6 +306,7 @@ EXTRA_HEADERS = \
>>  @HAVE_WIDL_TRUE@  include/devicetopology.idl \
>>  @HAVE_WIDL_TRUE@  include/downloadmgr.idl \
>>  @HAVE_WIDL_TRUE@  include/dxva2api.idl \
>> +@HAVE_WIDL_TRUE@  include/dxgidebug.idl \
>>  @HAVE_WIDL_TRUE@  include/endpointvolume.idl \
>>  @HAVE_WIDL_TRUE@  include/exdisp.idl \
>>  @HAVE_WIDL_TRUE@  include/filter.idl \
>> diff --git a/mingw-w64-headers/direct-x/include/dxgidebug.idl 
>> b/mingw-w64-headers/direct-x/include/dxgidebug.idl
>> new file mode 100644
>> index 0000000..94f57da
>> --- /dev/null
>> +++ b/mingw-w64-headers/direct-x/include/dxgidebug.idl
>> @@ -0,0 +1,44 @@
>> +/*
>> + * Copyright 2015 Steve Lhomme
>> + *
>> + * This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with this library; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>> + */
>> +
>> +import "oaidl.idl";
>> +
>> +cpp_quote("DEFINE_GUID(DXGI_DEBUG_ALL,   0xe48ae283, 0xda80, 0x490b, 0x87, 
>> 0xe6, 0x43, 0xe9, 0xa9, 0xcf, 0xda, 0x08);")
>> +cpp_quote("DEFINE_GUID(DXGI_DEBUG_DX,    0x35cdd7fc, 0x13b2, 0x421d, 0xa5, 
>> 0xd7, 0x7e, 0x44, 0x51, 0x28, 0x7d, 0x64);")
>> +cpp_quote("DEFINE_GUID(DXGI_DEBUG_DXGI,  0x25cddaa4, 0xb1c6, 0x47e1, 0xac, 
>> 0x3e, 0x98, 0x87, 0x5b, 0x5a, 0x2e, 0x2a);")
>> +cpp_quote("DEFINE_GUID(DXGI_DEBUG_APP,   0x06cd6e01, 0x4219, 0x4ebd, 0x87, 
>> 0x90, 0x27, 0xed, 0x23, 0x36, 0x0c, 0x62);")
>> +
>> +typedef enum DXGI_DEBUG_RLO_FLAGS {
>> +    DXGI_DEBUG_RLO_SUMMARY         = 0x0001,
>> +    DXGI_DEBUG_RLO_DETAIL          = 0x0002,
>> +    DXGI_DEBUG_RLO_IGNORE_INTERNAL = 0x0004,
>> +    DXGI_DEBUG_RLO_ALL             = 0x0007
>> +} DXGI_DEBUG_RLO_FLAGS;
>> +
>> +[
>> +    object,
>> +    local,
>> +    uuid(119e7452-de9e-40fe-8806-88f90c12b441)
>> +]
>> +interface IDXGIDebug : IUnknown
>> +{
>> +    HRESULT ReportLiveObjects(
>> +        [in] GUID apiid,
>> +        [in] DXGI_DEBUG_RLO_FLAGS flags);
>> +}
>> +
>> --
>> 2.4.0
>>
>>
>> ------------------------------------------------------------------------------
>> One dashboard for servers and applications across Physical-Virtual-Cloud
>> Widest out-of-the-box monitoring support with 50+ applications
>> Performance metrics, stats and reports that give you Actionable Insights
>> Deep dive visibility with transaction tracing using APM Insight.
>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>> _______________________________________________
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to