Hi Kai, On Aug 22 17:34, Kai Tietz wrote: > Hi Corinna, > > 2016-08-22 17:23 GMT+02:00 Corinna Vinschen <vinsc...@redhat.com>: > > Lots of assembler files in the math subdir check for _WIN64 when they > > actually mean to check for the x86_64 target CPU, rather than the target > > OS. This patch fixes it. This helps Cygwin in the first place because > > __x86_64__ is defined in both toolchains, while _WIN64 is only defined > > on Mingw-w64 for x86_64. > > > > > > Is that ok to apply? > > Patch is ok. Please apply.
Done, thanks! > PS: Does this mean you use these math functions on cywin? Not all of them but, yes, Cygwin does. The problem was that newlib only provided float and double, but no long double, so Cygwin is using the long double functions from Mingw-w64 and a few others for simplicity. Btw., we had to apply two Cygwin-specific patches to the math functions. I don't know if that's something we should share, but please have a look. I'm curious if that's stuff which should go upstream one way or the other: https://sourceware.org/git/?p=newlib-cygwin.git;a=commitdiff;h=929be80 https://sourceware.org/git/?p=newlib-cygwin.git;a=commitdiff;h=71df3bf Thanks, Corinna ------------------------------------------------------------------------------ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
