On 2017/5/3 12:46, David Grayson wrote: > I won't be offended if you revert it. I reverted it and added a line of comment explaining what had happened.
> I'm not sure what your shell commands do, but as long as there is one GUID > defined in one header file, and the selectany attribute is not used > properly, you can get multiple definition errors, because that header file > could be used in multiple translation units in conjunction with initguid.h. Those definitions are not in effect unless the macro `INITGUID` is defined, which is the case for our users. > It sounds like guiddef.h should probably check the GCC major version. > Based on the tests people have reported in this thread, I would guess that > for GCC 6 and above the selectany attribute on the declaration is required, > while on GCC 5 and below the selectany attribute on the declaration is > forbidden. Or we could get fancy and add a test to the configure script to > figure out which is the case. Both require citation from GCC documentation. But neither is an optimal solution IMHO. I suggest we ensure each GUID is defined only once then remove that attribute completely. -- Best regards, LH_Mouse ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
