LGTM On Fri, Aug 18, 2017 at 2:51 PM, Martin Storsjö <mar...@martin.st> wrote:
> Use -undef to avoid any compiler specific predefined definitions, > and use -P to skip the line markers - removing the need for the extra > sed command. > > The -w command to silence warnings is necessary, since otherwise > there are unnecessary warnings like these: > lib64/msvcrt.def.in:66:37: warning: missing terminating ' character > ; const __non_rtti_object::`vftable' > --- > mingw-w64-crt/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am > index 1600ac2..b6417ec 100644 > --- a/mingw-w64-crt/Makefile.am > +++ b/mingw-w64-crt/Makefile.am > @@ -1239,7 +1239,7 @@ endif > # ########## > > %.def: %.def.in > - $(MKDIR_P) $(@D) && $(CPP) -x c $< -Wp,-w > -I$(top_srcdir)/def-include | $(SED) 's/^#/;/' > $@ > + $(MKDIR_P) $(@D) && $(CPP) -x c $< -Wp,-w -undef -P > -I$(top_srcdir)/def-include > $@ > > # Don't compile these, but install as is: > # > -- > 2.7.4 > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
