在 2019/1/8 8:32, Mateusz 写道: > W dniu 08.01.2019 o 00:49, JonY pisze: >> On 1/7/19 5:50 PM, Mateusz wrote: >>> Old versions of MSVCRT _access() just ignored X_OK, while the >>> version shipped with Vista, returns an error code. >>> _access() from msvcr110/120 returns an error code for nul file. >>> >>> Signed-off-by: Mateusz Brzostek <mateu...@poczta.onet.pl> >> >> Patch looks OK. > > Thanks for review. > > There is one problem with this patch -- in 32-bit mode #include <windows.h> > implies #include <errno.h> only if it is set at least -msse2. In 32-bit MSVC > 2015 it is included even with options /arch:IA32 or /arch:SSE (/arch:SSE2 is > default for 32-bit). > > So it should be added > #include <errno.h> > to the patch (or we could fix mingw-w64 to load errno.h unconditionally when > we #include <windows.h>). > >
Pushed to master. GCC source code (either of GCC itself or libiberty) still needs patching for use of newer MSVCR*.DLL with an old version of mingw-w64, however. -- Best regards, LH_Mouse _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
