On Sat, 16 Mar 2019, Biswapriyo Nath wrote:

Windows 10 32bit has not WSL feature. See this link:
https://wpdev.uservoice.com/forums/266908-command-prompt-console-bash-on-ubuntu-on-windo/suggestions/13359735-add-x32-support
.

Only Windows 10 x86_64 and arm64 has that feature. Hence, I didn't add in
lib-common. If you want I'll do that.

The patch adds it to arm32, not to arm64 - that's wrong.

But even if it isn't available in all architectures, please add new def files in lib-common. Even if the file is in this shared directory, it only gets added in those architectures that actually add it to lib*/Makefile.am. So there's no point in duplicating the wslapi.def file in two directories when it could be just in one single place.

In general we are trying to refactor the existing files also to move as much as possible to lib-common, so please follow that style for new ones. If there is a need for architecture specific differences in files in lib-common, name the file .def.in, add an include for func.def.in and use ifdefs or macros from func.def.in to do the architecture specific adjustments. But that shouldn't be necessary for this small and simple interface.

// Martin



_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to