On Wednesday 26 January 2022 14:45:58 LIU Hao wrote:
> 在 1/26/22 04:05, Pali Rohár 写道:
> > 
> > Yes, this is truth. However amd64 asm code already reads more pointers
> > from stack (when number of them is smaller then number of arguments
> > needed to pass via registers when doing function call), so I think that
> > this function can be documented that returns "minimal number of
> > arguments".
> > 
> > So it is really an issue?
> > 
> > Or should be function extended to skip all characters between [ and ]?
> 
> For the sake of simplicity, I think it should be acceptable to return an
> upper limit, so I suggest we rename these functions to
> `__ms_scanf_max_arg_count_internal` etc. This also eliminates the need to
> check for `%*`; we only need to count `%` characters and assume there can be
> no more arguments than them.

Ok, I done it! I sent a new v2 patch version where I tried to address all
review comments.


_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to