On Sunday 03 March 2024 23:38:57 Martin Storsjö wrote:
> On Sun, 3 Mar 2024, Pali Rohár wrote:
> 
> > Ok, do you need me to resend this patch? Or would you fix this one
> > missing semicolon during applying patch?
> 
> I can fix the missing semicolon.
> 
> > And... I do not know how to better write the commit message, so I would
> > be happy if give me example of how to rephrase it.
> 
> Does this sound like a good commit message? If it's ok with you, I can push
> it in that form:
> 
> ---8<---
> crt: Fix comments in msvcrt-common.def.in
> 
> The ADD_UNDERSCORE macro adds an alias, without a leading underscore, for an
> existing export with a leading underscore.
> 
> For some functions, we're not providing these aliases, e.g. because those
> symbols are defined by other means, e.g. in source files (such as CRT_fp10.c
> and CRT_fp8.c).
> 
> This patch improves the style of those cases, which are listed as commented
> out instances of the ADD_UNDERSCORE macro.
> ---8<---
> 
> // Martin

That is nice, I like it! Thank you very much.


_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to