On Thu, 4 Apr 2024, Pali Rohár wrote:
On Friday 05 April 2024 00:02:02 Martin Storsjö wrote:
On Mon, 1 Apr 2024, Pali Rohár wrote:
---
mingw-w64-crt/lib-common/msvcrt.def.in | 136 ++++++++++++++++---------
1 file changed, 88 insertions(+), 48 deletions(-)
diff --git a/mingw-w64-crt/lib-common/msvcrt.def.in
b/mingw-w64-crt/lib-common/msvcrt.def.in
index 818d5149b156..71a6efcde3c9 100644
--- a/mingw-w64-crt/lib-common/msvcrt.def.in
+++ b/mingw-w64-crt/lib-common/msvcrt.def.in
@@ -369,12 +369,14 @@ _XcptFilter
F_ARM_ANY(__AdjustPointer)
F_NON_I386(__C_specific_handler)
__CppXcptFilter
+F_X86_ANY(__CxxCallUnwindDelDtor)
F_I386(__CxxCallUnwindDtor)
F_I386(__CxxCallUnwindVecDtor)
F_I386(__CxxDetectRethrow)
F_I386(__CxxExceptionFilter)
F_X86_ANY(__CxxFrameHandler)
-F_ARM_ANY(__CxxFrameHandler3)
+__CxxFrameHandler2
+__CxxFrameHandler3
F_I386(__CxxLongjmpUnwind@4)
F_I386(__CxxQueryExceptionSize)
F_I386(__CxxRegisterExceptionObject)
@@ -403,10 +405,10 @@ __crtGetLocaleInfoW
__crtGetStringTypeW
__crtLCMapStringA
__crtLCMapStringW
-F_ARM_ANY(__daylight)
+__daylight
__dllonexit
__doserrno
-F_ARM_ANY(__dstbias)
+__dstbias
These two symbols, __daylight and __dstbias, probably should be marked DATA
(based on their declaration in headers at least).
__daylight and __dstbias (with two leading underlines) are regular
functions, not global variables. mingw-w64-crt does not provide its own
replacement version for these functions.
No other def file marks them as DATA and neither gendef does not detect
these symbols as DATA in any my examined msvcrt.dll version.
So why should they be marked as DATA?
Sorry, I conflated them with the single-underscore _daylight and _dstbias.
Then this patch too should be fine, so I pushed it.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
