On Thu, Jul 25, 2024 at 6:29 PM LIU Hao <[email protected]> wrote: > 在 2024-07-25 21:42, [email protected] 写道: > > From: Marc-André Lureau <[email protected]> > > > > Signed-off-by: Marc-André Lureau <[email protected]> > > --- > > mingw-w64-crt/Makefile.in | 48 ++++++++++--------- > > mingw-w64-crt/lib-common/bcryptprimitives.def | 18 +++++++ > > mingw-w64-crt/lib32/Makefile.am | 1 + > > mingw-w64-crt/lib32/bcryptprimitives.def | 18 +++++++ > > mingw-w64-crt/lib64/Makefile.am | 1 + > > 5 files changed, 63 insertions(+), 23 deletions(-) > > create mode 100644 mingw-w64-crt/lib-common/bcryptprimitives.def > > create mode 100644 mingw-w64-crt/lib32/bcryptprimitives.def > > Thanks for the patch. There are some issues with this one: > > 1. Please exclude changes for generated files. (Makefile.in) >
should I make it a seperate patch? > 2. Please use LF instead of CR LF as line separators. > Ah, I didn't noticed (I used gendef.exe with wine). I'll strip those. 3. There is already 'bcryptprimitives.def' for ARM32; should it be removed? > 4. Should it be added for ARM64, too? > I have no clue about arm (title says x86) thanks _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
