Hello, what do you think about doing one-time automatic deduplication of
lib32 and lib-common def files?

Since commit cf211ae90565ff02e78c93d93a913501d100f30f ("crt: Remove
@<num> stdcall mangling when processing lib-common/*.def.in files for
non-I386 builds") Makefile can handle stdcall suffixes in lib-common def
files and hence it is possible to have just one def file for all archs,
even when i386 requires stdcall @<num>.

I was created very simple one-time script which checks if the lib32 and
lib-common def files are same after removing the @num in the same way
how it is doing Makefile.am.

    cd mingw-w64-crt
    for file in `ls lib32 | grep 'def$'`; do
        if ! test -e lib-common/$file; then continue; fi
        sed -E 's/^([^ ]+)@[0-9]+( |$)/\1\2/' < lib32/$file > 
lib-common/$file.tmp
        if cmp -s lib-common/$file lib-common/$file.tmp; then
            git rm lib-common/$file
            git mv lib32/$file lib-common/$file
        fi
        rm lib-common/$file.tmp
    done

And it deduplicated 496 def files. What do you think about it? Just a
robotic change and can decrease number of def files which needs to be
maintained.


_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to