On 23.05.2025 19:12, Martin Storsjö wrote:
On Fri, 23 May 2025, Jacek Caban via Mingw-w64-public wrote:
And use it for exports not available on ARM64EC.
---
mingw-w64-crt/def-include/func.def.in | 9 ++++++---
.../lib-common/api-ms-win-crt-math-l1-1-0.def.in | 2 +-
mingw-w64-crt/lib-common/msvcrt.def.in | 2 +-
mingw-w64-crt/lib-common/ntdll.def.in | 6 +++---
mingw-w64-crt/lib-common/ucrtbase-common.def.in | 4 ++--
5 files changed, 13 insertions(+), 10 deletions(-)
This looks good, thanks! But this really needs more of an explanation
in the commit message. I presume the intent is that F_ARM_NATIVE is
arm64 but not arm64ec, while the regular F_ARM_ANY is for both.
Yes, I assumed it's pretty clear from the line "And use it for exports
not available on ARM64EC." in my commit message.
This change also takes it into use for fabsf and a few other functions
- do mention that in the commit message. (I'm undecided if that should
be a separate commit or not. Keeping it in the same commit makes it
clearer how it is used at least.)
Sure, I listed them, but frankly, the patch is very short, and it should
be more than obvious from just a quick look.
It may also be worth pointing out the reason for the change - as this
differs from what I observed a few days ago: msvcrt.dll and
ucrtbase.dll in 10.0.22000.2057 _do_ have fabsf in the arm64ec/hybrid
view, while the function is missing in the hybrid view in the
10.0.22621.3593 version.
Sure, I added it to the commit message and pushed. Thanks!
Jacek
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
