Thank you for review. I wasn't sure if patches which group *functionally-related* function together are fine.
I've mentioned that I have spent some time in the past trying to sort-out [public, read as "documented by Microsoft"] CRT functions both by header file, their functionality and whether they are Standard C, Microsoft-specific or "POSIX". I could try to group related functions together when I will work on other header files. I like when header files contain not just unordered declarations, this especially applies to header files like stdlib.h which declare lots function for various tasks. I see, so we should avoid adding _CRTIMP for functions which are also declared in intrin.h. I'll keep that in mind. - Kirill Makurin ________________________________ From: LIU Hao Sent: Friday, January 16, 2026 2:33 PM To: [email protected]; Kirill Makurin Subject: Re: [Mingw-w64-public] De-duplicate declarations in conio.h and wchar.h 在 2025-12-20 09:12, Kirill Makurin 写道: > This is first patch series which aims to de-duplicate declarations in CRT > header files. This patch series covers functions declared in conio.h and > sec_api/conio_s.h, and their wide equivalents. It adds two new header files: > corecrt_wconio.h and sec_api/wconio_s.h. > > (I really thought that the header file was called "correct_wconio.h" and not > "corecrt_wconio.h" until I started writing this patch series) This is another example of typoglycemia. :) This series of patches look good to me, so pushed for now. > One thing I am not sure about is whether we need to add _CRTIMP for _inp[w|d] > and _outp[w|d] functions. They are also declared in intrin.h without _CRTIMP, > so I wasn't sure about it. Let me know if it needs to be added, in which case > I'll write a follow-up patch. No. Functions that are declared in intrin.h mostly should be implemented inline, maybe in assembly. -- Best regards, LIU Hao _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
