在 2026-1-9 19:09, Markus Muetzel via Mingw-w64-public 写道:
Good point.Instead of defining the value of pi in the appropriate type repeatedly, I opted for doing that in a header that can be included in all new compilation units. (That could be simplified if _Generic macros from C11 were allowed.)Does that look good to you?
Mostly looks good. There are two minor issues: One is that the parameter list to `atan2pi` is `y, x` by convention, not `x, y`; another is that the final clause in `__pi_type(x)` doesn't have to be `(__builtin_trap(),0)` as it's always unreachable, so `__builtin_trap()` suffices, in which case it is of type `void`.
If it passes the CI with these changes, I will go ahead and push this one. Thanks for the work. -- Best regards, LIU Hao
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
