On Tuesday 03 February 2026 16:14:02 LIU Hao wrote: > 在 2026-2-3 13:52, LIU Hao 写道: > > This series of patches are really messy. There are simple and obvious > > ones -- patch 1-6 and 11 -- which I can push if the CI passes. > > > > The others have big issues, for example, patch 7 adds code that is > > removed by patch 12, and an unidentified patch breaks ARM64EC. I am not > > willing to do lantern riddles; those must be squashed into one patch, > > before the issue can be addressed. > > Pushed those for now.
Ok, thanks! > For the remaining patches -- 7-8, 10 and 12 -- I squashed them into one > commit [1] but it caused linker errors for ARM64EC [2]. I don't see any > issue about the handler. I have a piece of code that is very similar to > yours, which doesn't fail on ARM64EC [3], so you will need to figure out > why. Could you please send me in attachment, that linker error? I will try to address it, and after fixing it I will send a new version of those changes. > Patch 9 isn't quite acceptable, as described earlier it passes a null > exception record pointer to `__C_specific_handler` whose parameter is not > expected to be null. However, the idea about code de-duplication probably > makes sense. I'd suggest that `_gnu_exception_handler` be removed if you can > replace all its references with `__mingw_SEH_error_handler` instead, both > from CRT and from winpthreads. > > > [1] > https://github.com/lhmouse/mingw-w64/commit/055191febaa30454a784937919a12853b8c2b530 > [2] > https://github.com/lhmouse/mingw-w64/actions/runs/21621032224/job/62309948289#step:5:2112 > [3] > https://github.com/lhmouse/mcfgthread/blob/24b4bd61e45fa88c05d0ef15700e2762a1c059e6/mcfgthread/xglobals.h#L279 Ok, I will look at this. Deduplication makes sense as basically the code contains same patterns and same functionality, just with different API. Also I have an another idea, use CRT function _XcptFilter. It should provide most of the _gnu_exception_handler / __mingw_SEH_error_handler functionality. I will try to write test cases and figure out if it could be replaced or if there is something missing, and it cannot be replaced. _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
