Pali Rohár <[email protected]> wrote:
>On Monday 22 June 2026 10:13:30 Kirill Makurin wrote:
>> Subject: [PATCH 4/4] crt: tests: update t_assert
>> ...
>
> I think that this is wrong change. Writing to the pipe can hung
> indefinitely if there is no active reader, so the process does not have
> to finish. Instead we should first read data from pipe (to make writer
> on other side to success and allow it to finish successfully).
Currently, call to read() always reads a single byte from pipe, which allows to
verify that assert() produced output, but does not allow us to examine the
message. If you think you can improve it, feel free to send your version of
changes.
> Adding "write (STDOUT_FILENO, buf, size);" is of course a good improvement.
>
> Anyway, you have an extra space between "write" and "(" which is not in
> other function calls in this file.
Good catch; I overlooked this.
- Kirill Makurin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
