在 2026-7-6 22:41, Kirill Makurin 写道:
Pali Rohár <[email protected]> wrote:"crt: improve _wassert() emulation" change is fine. This should be merged. I will prepare followup improvement for the "_set_error_mode" part as mentioned in the comment. About the "crt: remove mingw-w64 wrapper for _assert()". The current implementation is not perfect, but can be improvement. I'm still thinking how to handle it and improve it. So could you let the wrapper here for some time (before complete removal)?I think CRT `_assert` is just fine as is, without any mingw-w64 wrapper. The only limitation it has is that it is not working when `stderr` is set to Unicode translation mode. IMHO, this affects so few real-world projects that it is absolutely neglectable.
This is exactly the reason why I suggest you resolve all disagreement before sending a patch. If someone doesn't agree with you, then the probability that someone else also doesn't agree is likely high.
-- Best regards, LIU Hao
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
