Hey Anil, thanks a lot for your response =)

2016-11-03 11:03 GMT+01:00 Anil Madhavapeddy <[email protected]>:

> The existing tests aren't too OPAM-friendly either, since they are not
present in a `build-test` field (so the extra dependencies needed are not
auto installable).
>

Ok, I've put all the dependencies required for the test in the opam file.

>
> The trunk version of ocaml-crunch has had the interface changes from the
main mirage trunk applied, so you will need to `opam remote add dev
https://github.com/mirage/mirage-dev.git`
<https://github.com/mirage/mirage-dev.git> to get the development version
of all the right packages.
>
> After that, you will need to add `mirage-types-lwt {test}` as a test
dependency so that the right libraries are available in the opam file.
Once you have that, the tests should work.

Indeed, it exits correctly, but the results are t1.{cmi,cmx,o} files, I
think these should be linked with something else to see it working?

>
> The tests seem very basic at the moment, so writing a topkg + bos test
that writes the .ml files into _build/_tests, invokes the compiler on it,
and verifies that the resulting compiled ML outputs the crunched contents
would be useful.
>

Sounds great, I've tried to implement it in [1] (probably the least
idiomatic code ever :) please let me know how can I improve it), the last
compilation generates a consumer binary from [2] that is supposed to use
the crunched ml files. Not sure if this is the intended usage, I've been
reading through mirage-www (as an example that uses ocaml-crunch) and
mirage and haven't find the exact commands to get the contents from there,
I guess that some lwt composition might be involved. Is this the right
approach?

Cheers!

[1] https://github.com/mirage/ocaml-crunch/compare/master...
fgimenez:topkg?expand=1#diff-fa96e02582bba62b4c7d8bac70d3e8e7
[2] https://github.com/mirage/ocaml-crunch/compare/master...
fgimenez:topkg?expand=1#diff-75dff2ad9c3d30fad16c24c94d4bff0d
_______________________________________________
MirageOS-devel mailing list
[email protected]
https://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel

Reply via email to