> On 17 March 2011 05:10, Stuart Henderson <s...@spacehopper.org> wrote: >> On 2011/03/17 00:23, Christiano F. Haesbaert wrote: >>> On Wed, Mar 16, 2011 at 11:45:03PM +0000, Stuart Henderson wrote: >>> > On 2011/03/16 19:01, Christiano F. Haesbaert wrote: >>> > > On 10 March 2011 19:31, Christiano F. Haesbaert >>> > > <haesba...@haesbaert.org> >>> > > wrote: >>> > > > Hi, the following displays rejected icmp echo requests sent to >>> > > > bcast/mcast. >> [snip] >>> > > >>> > > Any feedback on this ? >>> > > >>> > >>> > It's ok with me, I'll probably commit it tomorrow unless there are >>> > objections or someone beats me to it. I considered removing the word >>> > 'rejected' to make it better fit the text style of other lines, but >>> > that would be incorrect as the counter is not incremented if >>> > net.inet.icmp.bmcastecho == 1. >>> >>> Sweet, I wasn't really sure about the text either. >> >> Actually I like this text better ('echo requests' instead of 'echo >> messages'), it's more precise. >>
Fine for me, I think it's better also, I chose messages just to match the other lines :P.