On 25 March 2011 12:54, Jason McIntyre <j...@cava.myzen.co.uk> wrote: > On Fri, Mar 25, 2011 at 09:44:33AM +0000, Glen Anderson wrote: >> >> "combined" is ok with me, it doesn't imply anything about how the >> figures are reached so side-steps the issues I had earlier. In the >> esoteric case I mentioned people will make their own (probably >> incorrect) assumptions with either wording. I've included a new diff >> making it clear that they're combined statistics. >> >> Ultimately I think there should be a note explaining what happens in >> the case of non-identical CPUs but without knowing what top does I'm >> happy with either of the following diffs. >> >> I'll have a dig through the source to see if I can find out. I'm not >> holding out much hope as "learn C" has been gathering dust on my todo >> list for a while... A bit of code reading won't do me any harm though. >> >> $ diff -u top.1 top.1.new >> --- top.1 B B B Thu Mar 24 12:39:45 2011 >> +++ top.1.new B Fri Mar 25 09:28:16 2011 >> @@ -75,7 +75,8 @@ >> B The options are as follows: >> B .Bl -tag -width Ds >> B .It Fl 1 >> -Display CPU statistics on a single line instead of a line per CPU. >> +Display combined CPU statistics on a single line instead of individual CPU >> +statistics on multiple lines. >> B .It Fl b >> B Use >> B .Em batch >> @@ -282,7 +283,8 @@ >> B .Sq P >> B interactive command. >> B .It 1 >> -Display CPU statistics on a single line instead of a line per CPU. >> +Toggle between combined CPU statistics on a single line and individual CPU >> +statistics on multiple lines. >> B .It C >> B Toggle the display of process command line arguments. >> B .It d Ar count >> > > ok, i committed a diff, but a little bit different to the one above. > funny how the simple diffs can make your head hurt most. in this case > i'm not sure i like the idea of toggling "between" states. i think you > toggle something on or off. god knows though. anyway i settled on the > diff below once i got fed up staring at the screen. > > jmc >
I'm happy with that diff, and don't think anymore time should be spent on something that people will very likely be playing with while reading the man page however I need to put this out there to stop my head hurting! I agree that the wording in previous diffs was a bit awkward however using the same wording as the C, I, S and T commands suggests that CPU statistics will either be on or off. "Toggle the display of CPU statistics between the states described in the -1 option." might be better. I'm going to drop this now and get back to more important things that also make my head hurt. > Index: top.1 > =================================================================== > RCS file: /cvs/src/usr.bin/top/top.1,v > retrieving revision 1.57 > diff -u -r1.57 top.1 > --- top.1 B B B 10 Aug 2010 20:34:16 -0000 B B B 1.57 > +++ top.1 B B B 25 Mar 2011 12:52:58 -0000 > @@ -75,7 +75,8 @@ > B The options are as follows: > B .Bl -tag -width Ds > B .It Fl 1 > -Display CPU statistics on a single line instead of a line per CPU. > +Display combined CPU statistics for all processors on a single line > +instead of one line per CPU. > B .It Fl b > B Use > B .Em batch > @@ -282,7 +283,7 @@ > B .Sq P > B interactive command. > B .It 1 > -Display CPU statistics on a single line instead of a line per CPU. > +Toggle the display of CPU statistics. > B .It C > B Toggle the display of process command line arguments. > B .It d Ar count
