Begin forwarded message:

Hi,

Yes this bug is still open because we've been focusing primarily on
fixing parts of smtpd that could cause crashes. We will be solving bugs
related to aliases shortly as Eric and I started discussing them just
an hour ago.

Feel free to join #opensmtpd @ freenode to participate ;)

Gilles

nb: jacekm no longer contributes to smtpd, in the future please cc:
eric@ and chl@


On Thu, Feb 02, 2012 at 02:48:21PM +0100, Christopher Zimmermann wrote:
> Hi,
> 
> I just noticed this bug is still outstanding. I have a patch attached
> that fixes this problem for me, but I was told there was some clean up
> to be done in lka_session.c before this can be fixed.
> 
> 
> Christopher
> 
> 
> Index: aliases.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/smtpd/aliases.c,v
> retrieving revision 1.44
> diff -u -p -r1.44 aliases.c
> --- aliases.c 11 Oct 2011 17:57:10 -0000      1.44
> +++ aliases.c 2 Feb 2012 13:48:03 -0000
> @@ -87,6 +87,8 @@ aliases_get(objid_t mapid, struct expand
>       /* foreach node in map_alias expandtree, we merge */
>       nbaliases = 0;
>       RB_FOREACH(expnode, expandtree, &map_alias->expandtree) {
> +             (void)strlcpy(expnode->as_user, username,
> +                     sizeof (expnode->as_user));
>               if (expnode->type == EXPAND_INCLUDE)
>                       nbaliases +=
> aliases_expand_include(expandtree, expnode->u.buffer); else {
> 
> 
> 
> On Sun, 11 Dec 2011 22:28:45 +0100
> Christopher Zimmermann <madro...@zakweb.de> wrote:
> 
> > Hi,
> > 
> > I want to use a pipe in my aliases, like this test case:
> > 
> > madroach:     |true
> > 
> > but smtpd says the following. Look especially for the
> > "forkmda: to true as" line. Seems like somewhere the username gets
> > lost.
> > 
> > Christopher
> > 
> > smtp_new: incoming client on listener: 0x3c00ad40
> > session_pickup: greeting client
> > imsg: PROC_CONTROL <- PROC_SMTP: IMSG_SMTP_ENQUEUE (len=0)
> > command: EHLO   args: localhost
> > imsg: PROC_MFA <- PROC_SMTP: IMSG_MFA_HELO (len=8128)
> > imsg: PROC_SMTP <- PROC_MFA: IMSG_MFA_HELO (len=9428)
> > command: MAIL FROM      args: <madro...@alix.ftp.sh>
> > session_rfc5321_mail_handler: sending notification to mfa
> > imsg: PROC_MFA <- PROC_SMTP: IMSG_MFA_MAIL (len=8128)
> > imsg: PROC_LKA <- PROC_MFA: IMSG_LKA_MAIL (len=9428)
> > imsg: PROC_MFA <- PROC_LKA: IMSG_LKA_MAIL (len=9428)
> > imsg: PROC_SMTP <- PROC_MFA: IMSG_MFA_MAIL (len=9428)
> > imsg: PROC_QUEUE <- PROC_SMTP: IMSG_QUEUE_CREATE_MESSAGE (len=8128)
> > imsg: PROC_SMTP <- PROC_QUEUE: IMSG_QUEUE_CREATE_MESSAGE (len=9428)
> > command: RCPT TO        args: <madro...@alix.ftp.sh>
> > imsg: PROC_MFA <- PROC_SMTP: IMSG_MFA_RCPT (len=8128)
> > imsg: PROC_LKA <- PROC_MFA: IMSG_LKA_RULEMATCH (len=9428)
> > imsg: PROC_MFA <- PROC_LKA: IMSG_LKA_RULEMATCH (len=9428)
> > imsg: PROC_LKA <- PROC_MFA: IMSG_LKA_RCPT (len=9428)
> > aliases_exist: 'madroach' exists with 1 expansion nodes
> > aliases_get: returned 1 aliases
> > lka_resolve_node: node is filter: true
> > imsg: PROC_QUEUE <- PROC_LKA: IMSG_QUEUE_SUBMIT_ENVELOPE (len=8128)
> > imsg: PROC_QUEUE <- PROC_LKA: IMSG_QUEUE_COMMIT_ENVELOPES (len=8128)
> > imsg: PROC_SMTP <- PROC_QUEUE: IMSG_QUEUE_COMMIT_ENVELOPES
> > (len=9428) command: DATA   args: (null)
> > imsg: PROC_SMTP <- PROC_QUEUE: IMSG_QUEUE_MESSAGE_FILE (len=9428)
> > imsg: PROC_QUEUE <- PROC_SMTP: IMSG_QUEUE_COMMIT_MESSAGE (len=8128)
> > imsg: PROC_RUNNER <- PROC_QUEUE: IMSG_QUEUE_COMMIT_MESSAGE
> > (len=8128) imsg: PROC_SMTP <- PROC_QUEUE: IMSG_QUEUE_COMMIT_MESSAGE
> > (len=9428) 5c8a626e: from=<madro...@alix.ftp.sh>, size=349,
> > nrcpts=1, proto=ESMTP, relay=1000@localhost [IPv6:::1]
> > command: QUIT   args: (null)
> > session_destroy: killing client: 0x89a3c000
> > runner: nothing to schedule, wake me up. zZzZzZ
> > imsg: PROC_QUEUE <- PROC_RUNNER: IMSG_MDA_SESS_NEW (len=8128)
> > imsg: PROC_MDA <- PROC_QUEUE: IMSG_MDA_SESS_NEW (len=8128)
> > imsg: PROC_PARENT <- PROC_MDA: IMSG_PARENT_FORK_MDA (len=1058)
> > forkmda: to true as
> > imsg: PROC_MDA <- PROC_PARENT: IMSG_MDA_DONE (len=23)
> > 5c8a626ea8724c2d: to=<madro...@alix.ftp.sh>, delay=0, stat=Error
> > (getpwnam: no such user)
> 

-- 
Gilles Chehade

https://www.poolp.org |
http://pool.ps                          @poolpOrg

Reply via email to