On Tue, May 28, 2013 at 20:54, Alexander Hall wrote:

> I do the 'mount -uw / do_stuff / mount -ur' dance as part of my backup
> system in order to minimize fsck time and disk corruption in case of
> unexpected power outages etc. I don't have softdep on those, but that's
> not really the point.
> 
> I can see situations where having to unmount and remount of a filesystem
> would be a nuisance. Are there any known problems with preserving the
> softdep bits (and even allow, albeit at that time ignore, them if
> present at 'mount -r')?

Indeed, I think maybe this is ok.

Index: ffs_vfsops.c
===================================================================
RCS file: /cvs/src/sys/ufs/ffs/ffs_vfsops.c,v
retrieving revision 1.136
diff -u -p -r1.136 ffs_vfsops.c
--- ffs_vfsops.c        15 Apr 2013 15:32:19 -0000      1.136
+++ ffs_vfsops.c        28 May 2013 20:50:42 -0000
@@ -221,7 +221,6 @@ ffs_mount(struct mount *mp, const char *
                                flags |= FORCECLOSE;
                        if (fs->fs_flags & FS_DOSOFTDEP) {
                                error = softdep_flushfiles(mp, flags, p);
-                               mp->mnt_flag &= ~MNT_SOFTDEP;
                        } else
                                error = ffs_flushfiles(mp, flags, p);
                        ronly = 1;

Reply via email to