On 2016-01-18, Andreas Kusalananda Kähäri <andreas.kah...@icm.uu.se> wrote:
> Hi,
>
> I tried running the base system build with CC="ccache cc" and it broke
> while compiling libiberty due to an unquoted expansion of ${CC} in the
> Makefile ("${MAKE} ${GNUCFLAGS} CC=${CC} needed-list").
>
> I know I won't save much time by using ccache since the compiler is
> rebuilt during the process, but I assume that a similar problem would
> arise if one tried to use CC="distcc cc", for example. Also, other
> Makefiles in the tree quotes ${CC}, and this is *almost* the sole
> instance where it's not quoted. Other instances are
> lib/libcrypto/crypto/arch/{mips64,sparc64}/Makefile.inc
I agree with this, but send it to tech@.
> Patch:
>
> Index: Makefile.bsd-wrapper
>===================================================================
> RCS file: /cvs/src/gnu/lib/libiberty/Makefile.bsd-wrapper,v
> retrieving revision 1.15
> diff -u -p -u -r1.15 Makefile.bsd-wrapper
> --- Makefile.bsd-wrapper 31 Aug 2014 01:02:48 -0000 1.15
> +++ Makefile.bsd-wrapper 18 Jan 2016 15:28:44 -0000
> @@ -32,7 +32,7 @@ CLEANFILES+= Makefile config.cache confi
> depend: needed-list
>
> needed-list: config.status
> - ${MAKE} ${GNUCFLAGS} CC=${CC} needed-list
> + ${MAKE} ${GNUCFLAGS} CC="${CC}" needed-list
>
> config.status: Makefile.in configure
> PATH="/bin:/usr/bin:/sbin:/usr/sbin" \
>
>
>
> --
> Andreas Kusalananda K�h�ri, Bioinformatics Developer, Uppsala, Sweden
> OpenPGP: url=https://db.tt/2zaB1E7y; id=46082BDF
> ------------------------------------------------------------------------
>
> [demime 1.01d removed an attachment of type application/pgp-signature which
> had a name of signature.asc]
