On Wed, May 10, 2017 at 12:51:45PM +0000, Michal Bozon wrote:
> There was a "typo" in my patch, this should be a correct one:
> 
> --- /usr/src/distrib/miniroot/install.sub.ooo   Wed May 10 12:19:56 2017
> +++ /usr/src/distrib/miniroot/install.sub       Wed May 10 12:48:31 2017
> @@ -1804,7 +1804,7 @@
>          fi
>  
>          # Always mount msdos partitions with -s to get lower case names.
> -        grep -q "^  $resp: .*MSDOS" $_file && _opts="-s"
> +        grep -q "^  $resp: .*MSDOS" $_file && _opts="-l"
>          mount -o ro,$_opts /dev/$_dev$resp /mnt2
>  }
> 
> I am not sure why "-s" flag is used, maybe it fixed some problem,
> but it has introduced another one.

A similar diff was briefly committed in 1.750 for the reason you mention:
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/distrib/miniroot/install.sub#rev750
It was backed out again in
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/distrib/miniroot/install.sub#rev752

> 
> MB
> 
> 
> On 2017-05-10 Wed 12:34, Michal Bozon wrote:
> > Hi,
> > there is a typo in install.sub
> > causing problems e.g. when removable FAT32 formatted
> > disk with installation files is attached,
> > and "disk" is selected as install media:
> > 
> > INSTALL.i386 not found ...
> > (because it is visible as instal~1.i38)
> > 
> > Directory does not contain SHA256.sig ...
> > (because it is visible as sha256.sig)
> > 
> > here is the patch:
> > 
> > --- /usr/src/distrib/miniroot/install.sub
> > +++ /usr/src/distrib/miniroot/install.sub
> > @@ -1805,7 +1805,7 @@
> >  
> >          # Always mount msdos partitions with -s to get lower case names.
> >          grep -q "^  $resp: .*MSDOS" $_file && _opts="-s"
> > -        mount -o ro,$_opts /dev/$_dev$resp /mnt2
> > +        mount -o ro $_opts /dev/$_dev$resp /mnt2
> >  }
> > 
> > 
> > regards,
> > Michal Bozon
> 

Reply via email to