Re: xterm not opening on latest snapshot?

[Dave Voutila]

henkjan gersen <h.ger...@gmail.com> writes:

> On this mornings snapshot that I just upgraded to I can no longer open
> an xterm window. Based on the .xsession-error this must be related to
> the unveil capabilities that got added last week as I see "xterm:
> unveil" appearing in that file.
>
> Can someone give a hint on what I'm missing to be able to open an
> xterm window again?

Can you try again with this diff? It should add logging and specify
which unveil is failing.


Index: app/xterm/main.c
===================================================================
RCS file: /cvs/xenocara/app/xterm/main.c,v
retrieving revision 1.50
diff -u -p -r1.50 main.c
--- app/xterm/main.c    2 Sep 2021 09:31:38 -0000       1.50
+++ app/xterm/main.c    5 Sep 2021 13:58:13 -0000
@@ -2911,18 +2911,18 @@ main(int argc, char *argv[]ENVP_ARG)

                 snprintf(homefile, sizeof homefile, "%s/.fonts", env);
                 if (unveil(homefile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", homefile);
                     exit(1);
                 }
                 snprintf(homefile, sizeof homefile, "%s/.cache/fontconfig",
                          env);
                 if (unveil(homefile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", homefile);
                     exit(1);
                 }
                 snprintf(homefile, sizeof homefile, "%s/.icons", env);
                 if (unveil(homefile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", homefile);
                     exit(1);
                 }
             }
@@ -2931,12 +2931,12 @@ main(int argc, char *argv[]ENVP_ARG)

                 snprintf(xdgfile, sizeof xdgfile, "%s/fontconfig", env);
                 if (unveil(xdgfile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", xdgfile);
                     exit(1);
                 }
                 snprintf(xdgfile, sizeof xdgfile, "%s/icons", env);
                 if (unveil(xdgfile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", xdgfile);
                     exit(1);
                 }
             }
@@ -2945,12 +2945,12 @@ main(int argc, char *argv[]ENVP_ARG)

                 snprintf(xdgfile, sizeof xdgfile, "%s/fontconfig", env);
                 if (unveil(xdgfile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", xdgfile);
                     exit(1);
                 }
                 snprintf(xdgfile, sizeof xdgfile, "%s/icons", env);
                 if (unveil(xdgfile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", xdgfile);
                     exit(1);
                 }
             }
@@ -2959,7 +2959,7 @@ main(int argc, char *argv[]ENVP_ARG)

                 snprintf(xdgfile, sizeof xdgfile, "%s/fontconfig", env);
                 if (unveil(xdgfile, "r") == -1) {
-                    xtermWarning("unveil\n");
+                    xtermWarning("unveil %s\n", xdgfile);
                     exit(1);
                 }
             }
@@ -2970,7 +2970,7 @@ main(int argc, char *argv[]ENVP_ARG)
                 (unveil("/usr/local/lib/X11/icons", "r") == -1) ||
                 (unveil(etc_utmp, "w") == -1) ||
                 (unveil(etc_wtmp, "w") == -1)) {
-                xtermWarning("unveil\n");
+                xtermWarning("unveil many, %s, %s\n", etc_utmp, etc_wtmp);
                 exit(1);
             }