On Mon, May 08, 2023 at 12:28:58AM +0200, Rogier Krieger wrote: > While diagnosing an unrelated matter, I find that 'bgpctl show rib' > has difficulty with the 'in' keyword. The 'out' counterpart works as > expected. Looking at bgpctl(8), the following should work (but > doesn't): > $ bgpctl show rib in neighbor $peer > ambiguous argument: in > valid commands/args: > <snip> > invalid > leaked > in > out > <snip> > > Note: tested this on a 7.3 (w/ bgpd erratum) release system. > On a 7.2 release system, I don't see this regression (unsurprising, as > bgpctl(8) there doesn't list 'invalid' as a valid 'show rib' option). > > I suspect this involves the logic in match_token() from > src/usr.sbin/bgpctl/parser.c. I'll take a stab at providing a patch. > Meanwhile, I'd appreciate any hints and/or a workaround for the mean > time.
Ugh. This broke with the introduction of "invalid" as keyword. The parser is not smart enough to handle keywords with equal prefix. Using a different word that does not start with "in" would be the simplest fix. -- :wq Claudio
