On Wed, Oct 8, 2008 at 1:08 PM, Otto Moerbeek <[EMAIL PROTECTED]> wrote: > On Wed, Oct 08, 2008 at 12:44:43PM -0700, Philip Guenther wrote: >> On Wed, Oct 8, 2008 at 12:27 PM, Peter J. Philipp <[EMAIL PROTECTED]> wrote: >> > I'm not just seeing this wrong I hope. Let me explain: >> > >> > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_tun.c >> > >> > when looking at the top seeing the change 1.95 done by brad@, but when >> > selecting to see diffs with 1.94 the change in $OpenBSD$ tag reflects >> > damien >> > and mpf who were the committers one commit before 1.95. This causes a bit >> > of confusion on my part, for who committed what, what are brad's changes? >> > >> > Is CVSWEB broken? >> >> No, that's just the way CVS keywords work: the expansion is done at >> *checkout* and not at commit. This can be seen using the -ko option >> to "cvs up" or "cvs co" to disable the expansion done at checkout >> time. Just trust what you see on the revision listing and ignore the >> keywords in the diff output. > > but when I do a > > cvs diff -r 1.94 -r 1.95 if_tun.c > > on my local mirror i'm seeing the right $OpenBSD$ markers. Compere the > output below to > > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_tun.c.diff?r1=1.94&r2=1.95 > > I'd say something's fishy here.
Hmm, good point. It's like it passes the -ko option to cvs diff. Or does cvsweb implement the diff itself internally? It has to peek directly at the RCS files to get some of the other stuff it shows, no? Philip Guenther
