On Thu, Aug 21, 2008 at 3:58 PM, Paul de Weerd <we...@weirdnet.nl> wrote: > Works for me. > > (haven't tested this very extensively yet, and only OpenBSD <-> > OpenBSD ... nor did I try the tcpdump patches .. will do so later) > > Thanks Reyk, cool stuff ;) > > Paul 'WEiRD' de Weerd > - Show quoted text - > On Thu, Aug 21, 2008 at 09:34:12PM +0200, Reyk Floeter wrote: > | On Thu, Aug 21, 2008 at 04:05:50PM +0200, Claudio Jeker wrote: > | > > no point in just doing that. > | > > > | > > a button to change the ether type would make sense. > | > > > | > > | > | this is not trivial because it would require a change in the Rx path > | where it is currently matching the ethertype in ether_input() before > | calling vlan_input(). do you want to call vlan_input() for every > | other packet or do a configured type lookup all the time? and what if > | the user specifies an ethernet type that is conflicting with something > | else? i think it should really only be 0x8100 or 0x88a8. > | > | > If we stack vlan interfaces I don't see a real need for such a button. > | > This could be figured out either at configuration time or on runtime. > | > E.g. just check if the ethertype is 0x8100 and add the next vlan tag as > | > 0x88a8. This would also allow to use a bridge for qinq setups. Because of > | > this I think doing it on runtime is the best. > | > > | > | here is another approach defining QinQ-compliant interfaces as a new > | cloner type; so you can stack 0x88a8 devices as you wish and it > | doesn't need a new button in ifconfig. it also uses a dedicated vlan > | tag hash for "Service VLANs" to avoid tag/Id conflicts. > | > | # ifconfig em0 up > | # ifconfig svlan100 vlandev em0 > | # ifconfig vlan200 vlandev svlan100 192.168.2.100 > | > | reyk
I have a need for this patch and I would like to test it on OpenBSD 4.5. the patch no longer applies in part because of changes to if_bridge.c in Revision 1.173 I was wondering if someone had a updated patch laying around, also what is the likelihood of this patch ever getting committed? Sam Fourman Jr. Fourman Networks
